16992 - Multipart related messages are duplicating body text

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[rhp (gone)]

This is caused by the differences in behavior of nsString and nsCString. if you
do the following:

nsString me;

me.Append("this is a fun buffer", 0);

it will do the right thing and append nothing. BUT, an nsCString appends the
entire string.

It's an easy fix that I will attach to this bug report.

Scott, can you review it for me.

Comment 1

[rhp (gone)]

Attachment: The fix

Comment 2

[Scott MacGregor]

Hmm it confuses me since both nsCString and nsString share the same
implementation (as to why using one or the other would make a difference).

But your addition looks harmless so if it fixes something then I say go for it
=).

Comment 3

[lchiang]

adding esther to cc: list.  Esther - this is what you were mentioning to me
today. No need to file a bug :-)

Comment 4

[rhp (gone)]

This should be all better now.

- rhp

Comment 5

[pmock]

changing QA assigned to myself

Comment 6

[pmock]

Verified as fixed on win32, macos, and linux using the following builds:
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/1999-12-21-09-M13/sea
monkey32e.exe
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/1999-12-21-08-
M13/netscape-i686-pc-linux-gnu.tar.gz
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-12-21-08-M13/NSMacIn
staller-M13.sea.bin

I tested using a multi-related mail message.  The text was not duplicated.

Comment 7

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/b910fce878fa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16992: Align clipboard link and text with scan button.