170429 - Seamonkey broke tabbing on Linux. We can fix it.

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Asa Dotzler [:asa]]

Bug 140612 implemented "break tabbing in linux". We can and should set the pref
to "not broken".

Comment 1

[Brendan Eich [:brendan]]

This shouldn't be fixed in Phoenix only.  The default pref should be as it was
in mozilla1.0.  I'm morphing Product and Component.

/be

Comment 2

[Christopher Blizzard (:blizzard)]

Yeah, this totally breaks using the UI, period.  I can't change text boxes, I
can't read mail easily - wow.  Please, it hurts!  Put it back!

Comment 3

[Brendan Eich [:brendan]]

Attachment: proposed fix, Unix only

Looking for testing, r= and sr= tonight.

/be

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 100367 [details] [diff] [review]
proposed fix, Unix only

r=blizzard

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Which way do mac users want their pref?  (Or do they use tabbing at all?)

Comment 6

[David Hyatt]

Comment on attachment 100367 [details] [diff] [review]
proposed fix, Unix only

sr=hyatt

Comment 7

[Brendan Eich [:brendan]]

I'll let Mac users fend for themselves in another bug.

blizzard tested, I checked in.

/be

Comment 8

[sairuh (rarely reading bugmail)]

setting qa contact to myself and cc'ing the keybd nav component owner, aaronl.

Comment 9

[Akkana Peck]

Do you really think most unix users want links too?  Not, say, 3 (all form
elements but not links, so that it's possible to tab usefully to form elements
without having to go through 40 links first)?  Is it worth asking on
mozilla-unix, or is it a done deal and we're not really interested in discussion?

Comment 10

[Brendan Eich [:brendan]]

I think we want what we shipped in 1.0.

Speaking for myself, I know I want links.  But before anything changes from 1.0
there needs to be a lot more discussion and obvious cries for change than there
were when bug 140612's patch went in.  It seems to me you're not going to find a
clear majority in favor of any setting (I could be wrong), so the pref is a good
thing to have, but the default should stay the way it has been for quite some
time.  That's why this bug got fixed fast.

/be

Comment 11

[sairuh (rarely reading bugmail)]

vrfy'd fixed. like win32, in linux tabbing hits all focusable elements.