170611 - PPEmbed - AlertCheck dialog has a "Cancel" button. It shouldn't.

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Teruko Kobayashi]

PPEmbed - "Cancel" button does not work in warning dialog when accessing an
encrypted website.

Steps of reproduce
1. Launch PPEmbed 
2. Go to www.citibank.de
3. click on "Zu Ihrem Konto & Depot"
The waring dialog "You have requested an encrypted page..." will show up.
4. click on the "Cancel" button in the upcoming info form

Actual Result
nothing happens

Expected Result
either the button should have an action or the button should be removed.

Tested 9-19 branch PPEmbed build.

Comment 1

[Conrad Carlen (not reading bugmail)]

OK - I see the problem and know what it is. I was a side-tracked by the fact
that the page didn't load ;-)

Fixing summary.

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: patch

The same dialog resource for nsIPromptService::ConfirmCheck was being used for
nsIPromptService::AlertCheck.

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: updated resource file

Added the right dialog resource for AlertCheck, fixed up the dialogs to be
wider, and the checkboxes to be taller. Also, fixed the size/placement bindings
in the dialogs so that apps wanting larger dialogs for larger dialog fonts can
more easily change this in Constructor while preserving the layout of items.

Comment 4

[Michael Dunn]

Internal reference:
http://bugscape.mcom.com/show_bug.cgi?id=20193

Comment 5

[Sheela Ravindran]

mozilla build 1.0.2 Gecko 20020925

I am able to reproduce this problem. But under steps to reproduce after #3 I had
to click on the back arrow button to get the warning dialog.  
Clicking Cancel does not dismiss the dialog at all.

Workaround: If you click on OK twice it will take you back to www.citibank.de

Comment 6

[Conrad Carlen (not reading bugmail)]

> Workaround: If you click on OK twice it

Hello, there is a patch here ;-) There is *not* supposed to be a cancel button.

Comment 7

[Conrad Carlen (not reading bugmail)]

Can I get r=/sr= on this? The patch is mostly to resources so there's not much
to see but it's explained in comment #2 and #3.

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 100486 [details]
updated resource file

rs=sfraser

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 100485 [details] [diff] [review]
patch

r=pink

Comment 10

[Conrad Carlen (not reading bugmail)]

Fixed