170951 - IME should use OS system color for selection instead of inverting

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P1)

Description

[Kathleen :Brade]

When typing with IME, I expect it to use the system color rather than inverting.
 I spoke with Frank Tang briefly and he said it'd be ok to submit a patch that
was not OS specific to use the system selection color instead of inverting the rect.

Comment 1

[Kathleen :Brade]

Attachment: patch to hilite IME with selection color instead of inverting

This patch leaves the old code available (via #if 0) for the time being.  I
hesitate to remove it entirely until it has landed and there are no major
complaints on any platforms.

Simon--I intend to land this on the Chimera branch, please sr= for trunk as
well as Chimera branch.

Comment 2

[Oliver Klee]

*** Bug 170950 has been marked as a duplicate of this bug. ***

Comment 3

[Simon Fraser [no longer active]]

Doesn't cocoa have its own color (yellow) for such selection? Should we add to
nsILookAndFeel to get this color?

Comment 4

[mjudge]

this code looks like it should work. put me for an r= if you like.  I talked to
kathy and I suggested that maybe putting an #if IME_INVERT instead of the #if 0
and adding the #if !IME_INVERT around all the new code.  so we can quickly
compile it one way or the other.  then once ime users can whack on the new way
and it passes mustard, we remove all the #ifs.  however you decide is cool.

Comment 5

[Mike Pinkerton (not reading bugmail)]

r=pink, but use an ifdef label rather than #if 0 so we know what's going on and
can find it more easily later.

Comment 6

[Kathleen :Brade]

Attachment: updated patch which landed on Chimera branch

Comment 7

[Kathleen :Brade]

Comment on attachment 101163 [details] [diff] [review]
updated patch which landed on Chimera branch

carry forward r= from pinkerton and mjudge

Comment 8

[Katsuhiro MIHARA]

*** Bug 236996 has been marked as a duplicate of this bug. ***

Comment 9

[Eiichi]

Attachment (id=101163) once landed on Chimera 1.7.1 branch, but didn't land on
trunk.
Are there any problems?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This patch should not be check-in to Trunk.
Because it is XP source code, not for only Mac.

Please wait, I will re-implement IME composition string rendering soon.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 159263 has been marked as a duplicate of this bug. ***

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I take this bug.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 312838 has been marked as a duplicate of this bug. ***

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

fixed by bug 113161.

-> FIXED