172194 - Initial focus in password dialogs messed up

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

[guessing at the component]
1. go to above url
2. notice focus is not in the username field

build id 2002100109, win98

this is a regression.

also happens for news username/password, like news://news.cis.dfn.de/at.linux

probably also for IMAP/POP password prompts, but I can't check right now.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

To clarify, the focus is on the OK button

Comment 2

[Aaron Leventhal]

Attachment: Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

Comment 3

[Samir Gehani]

Comment on attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

r=sgehani

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

sr=bryner

Comment 5

[Aaron Leventhal]

checked in

Comment 6

[[e-mail]]

Comment on attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

>-  if (setCheckbox(gCommonDialogParam.GetString(1), gCommonDialogParam.GetInt(1)))
>+  if (setCheckbox(gCommonDialogParam.GetString(1), gCommonDialogParam.GetInt(1)) &&
>+      gCommonDialogParam.GetInt(3) == 0)  // if no text fields

Unfortunately I didn't have sufficiently reliable internet access otherwise I
would have posted my solution which only checks GetInt(3) although I expect
that the extra test doesn't hurt.