172302 - unify unicodeToEntity

Status: RESOLVED INCOMPLETE

(Other Applications :: DOM Inspector, enhancement)

Description

[timeless]

view partial source and dom inspector have very similar functions which could be
unified. We should consider doing this, but we don't have to do it today :).

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass re-assigning bugs to [e-mail]

Comment 2

[Shawn Wilsher :sdwilsh]

We can use this in everything becuase it is part of toolkit, right?  My only concern is Seamonkey.

http://lxr.mozilla.org/seamonkey/source/toolkit/components/viewsource/content/viewPartialSource.js#467

Comment 3

[Boris Zbarsky [:bzbarsky]]

There are parts of toolkit that are actually toolkit and parts that are not, apparently.  Talk to a toolkit peer about what parts of toolkit are guaranteed to be present in all XULRunner apps, then if this is one of those parts talk to the seamonkey UI folks to make sure it gets built in Seamonkey.

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> There are parts of toolkit that are actually toolkit and parts that are not,
> apparently.  Talk to a toolkit peer about what parts of toolkit are guaranteed
> to be present in all XULRunner apps, then if this is one of those parts talk to
> the seamonkey UI folks to make sure it gets built in Seamonkey.

<gavin>	its apparently enabled for everything but MOZ_EMBEDDING_PROFILE=(basic|minimal)

So, we are good to use that code then, correct?

Comment 5

[Boris Zbarsky [:bzbarsky]]

We would be if everything were a XULRunner app... sadly, I doubt it is -- for example I just don't see the relevant files in a Seamonkey objdir (something you could have checked on yourself, btw).

Comment 6

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: Use unicodeTOentity from viewPartialSource; remove associated now-dead code (including _toXML)

Comment 7

[[e-mail]]

Comment on attachment 536817 [details] [diff] [review]
Use unicodeTOentity from viewPartialSource; remove associated now-dead code (including _toXML)

I don't think viewPartialSource's unicodeTOentity is suitable as it includes HTML markup to highlight the entity.

Interestingly I notice that the XML serialiser only encodes the basic entities.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 12

[Firefox Bug Husbandry Bot]

Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023

Comment 13

[Firefox Bug Husbandry Bot]

Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023