Closed
Bug 172833
Opened 22 years ago
Closed 22 years ago
need support for a conditional interface map entry
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: darin.moz, Assigned: dougt)
References
()
Details
Attachments
(1 file, 2 obsolete files)
6.16 KB,
patch
|
darin.moz
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
there's a number of conditional QI's out there that sort of take advantage of the QI macros. for example, http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsStandardURL.cpp#803 http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/viewsource/src/nsViewSourceChannel.cpp#53 it probably makes sense to come up with a macro for this. how about NS_INTERFACE_MAP_ENTRY_CONDITIONAL or NS_INTERFACE_MAP_CONDITIONAL_ENTRY?
Assignee | ||
Comment 1•22 years ago
|
||
yeah, I think it is a good idea.
Assignee | ||
Comment 2•22 years ago
|
||
hmm. Condition first. new patch coming up.
Assignee | ||
Comment 3•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Attachment #102012 -
Attachment is obsolete: true
Comment 4•22 years ago
|
||
> + NS_INTERFACE_MAP_ENTRY_CONDITIONAL(nsIURL, mSupportsFileURL)
nsIFileURL you mean?
Also, could you thwack nsViewSourceChannel too, while you're doing this?
Assignee | ||
Comment 5•22 years ago
|
||
Just checking to see if you were awake! :-)
Attachment #102014 -
Attachment is obsolete: true
Comment 6•22 years ago
|
||
Comment on attachment 102016 [details] [diff] [review] three three three r/sr=bzbarsky. Being awake is overrated. ;)
Attachment #102016 -
Flags: superreview+
Assignee | ||
Comment 7•22 years ago
|
||
especially when the reviewers are awake! thanks.
Reporter | ||
Comment 8•22 years ago
|
||
Comment on attachment 102016 [details] [diff] [review] three three three > // see nsStandardURL::Equals > if (aIID.Equals(kThisImplCID)) > foundInterface = NS_STATIC_CAST(nsIURI *, this); > else > NS_INTERFACE_MAP_END grr... so i guess it doesn't solve this one. oh well :( r/sr=darin
Attachment #102016 -
Flags: review+
Assignee | ||
Comment 9•22 years ago
|
||
Checking in xpcom/glue/nsISupportsImpl.h; /cvsroot/mozilla/xpcom/glue/nsISupportsImpl.h,v <-- nsISupportsImpl.h new revision: 3.18; previous revision: 3.17 done Checking in netwerk/base/src/nsStandardURL.cpp; /cvsroot/mozilla/netwerk/base/src/nsStandardURL.cpp,v <-- nsStandardURL.cpp new revision: 1.39; previous revision: 1.38 done Checking in netwerk/protocol/viewsource/src/nsViewSourceChannel.cpp; /cvsroot/mozilla/netwerk/protocol/viewsource/src/nsViewSourceChannel.cpp,v <-- nsViewSourceChannel.cpp new revision: 1.15; previous revision: 1.14 done thanks
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•