173280 - download dialog comes up even though FTP server can't be found

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Judson Valeski]

problem: when visiting said URL, can clicking on the "301 or later" download
link in the right column, a save-as dialog is thrown, then a download progress
dialog. a file of zero length gets created on the file system, however, the ftp
server isn't even accessible.

expected results: a dialog gets thrown telling the user the server can't be reached.

Comment 1

[Matthias Versen [:Matti]]

dupe of the old bug 63798

*** This bug has been marked as a duplicate of 63798 ***

Comment 2

[Doug Turner (:dougt)]

not so fast....  this is clearly a new regression.  

Comment 3

[Doug Turner (:dougt)]

the nsOnStopRequestEvent depends on the request having the a valid status. 
however, we are not setting the internal state before making use of this event.  

This patch fixes it for me.

Index: nsFtpConnectionThread.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v
retrieving revision 1.250
diff -u -r1.250 nsFtpConnectionThread.cpp
--- nsFtpConnectionThread.cpp	30 Sep 2002 21:50:17 -0000	1.250
+++ nsFtpConnectionThread.cpp	9 Oct 2002 04:55:34 -0000
@@ -2381,6 +2381,8 @@
     if ( NS_SUCCEEDED(broadcastErrorCode))
         broadcastErrorCode = mInternalError;
 
+    mInternalError = broadcastErrorCode;
+
     if (mDPipeRequest && NS_FAILED(broadcastErrorCode))
         mDPipeRequest->Cancel(broadcastErrorCode);
     

Can I get a r/sr?  

Comment 4

[Darin Fisher]

sr=darin

Comment 5

[neeti]

r=neeti

Comment 6

[Matthias Versen [:Matti]]

sorry for incorrect duping....

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin

Comment 8

[Doug Turner (:dougt)]

I landed this sometime last week.  Marking Fixed.

Comment 9

[Jimmy Lee]

Build: 2002-10-25-04-trunk

A dialog appears indicating server cannot be reached.  This reflects expected
behavior.  Marking Verified!