Closed Bug 173561 Opened 22 years ago Closed 13 years ago

request flags should use a #define instead of masking w/ 0xffff

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jesup, Assigned: jesup)

Details

Attachments

(1 file)

Simple fix
2.48 KB, patch
Biesinger
: review+
jesup
: checkin+
Details | Diff | Splinter Review 
In several places (imgLoader.cpp, nsLoadGroup.cpp, etc) there is code that masks
requestflags with 0xFFFF to separate the low 16 bits from the top 16 used by
subclasses.  This should be a #define, as per our discussion in IRC.
Status: NEW → ASSIGNED
Priority: -- → P5
Target Milestone: --- → mozilla1.3alpha
Target Milestone: mozilla1.3alpha → Future
-> default owner
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: benc → networking
Target Milestone: Future → ---
Attached patch Simple fix — — Splinter Review 
Turns out the hard constant 0xFFFF was still sitting in imgLoader.cpp and nsLoadGroup.cpp 9 years later...

Simple fix.  It doesn't appear to be elsewhere, other than those two files.

Guessing from r= in imgLoader.cpp that Joe Drew is appropriate for review.
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Attachment #537732 - Flags: review?(joe)
Attachment #537732 - Flags: review?(joe) → review?(cbiesinger)
Attachment #537732 - Flags: review?(cbiesinger) → review+
Checked in: http://hg.mozilla.org/mozilla-central/rev/26a8cb097609
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #537732 - Flags: checkin+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: