174210 - (servisco.com.pl) servisco.com.pl - Clickable map uses document.all

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: Polish, defect, P3)

Description

[Gabriel Baines]

The problem is with http://www.servisco.com.pl/html/mapa.htm page, that can be
reached from http://www.servisco.com by clicking 'O firmie' -> 'Adresy'. 

The page shows a clickable map of Poland. Unfortunatelly, the JavaScript code
that handles it tries to use document.all or document.layers. Since none of them
exist in Mozilla DOM, clicks on the map are silently ignored.

Note: the problem has been originally reported on MozillaPl.org forum: 
http://mozillapl.org/forum/viewtopic.php?t=980

Comment 1

[Jacek Piskozub]

Accepting.

Comment 2

[Jacek Piskozub]

Accepting for real.

Comment 3

[Jacek Piskozub]

For the map to work it is enough to add one line changing

function MM_findObj(n, d) { //v3.0
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++)
x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++)
x=MM_findObj(n,d.layers[i].document); return x;
}

into 

function MM_findObj(n, d) { //v3.0
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n];
  if(!(x=d[n])&&d.getElementById) x=d.getElementById(n);
  for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++)
x=MM_findObj(n,d.layers[i].document); return x;
}

The actuall addition is 
  if(!(x=d[n])&&d.getElementById) x=d.getElementById(n);

Comment 4

[Jacek Piskozub]

The contact address innthe source of the map page is [e-mail]
Servisco contact address (probablu useless fo us) is [e-mail]

Comment 5

[Jacek Piskozub]

I sent a modified LAYERS letter, suggesting the above mentioned change to both
the addresses from comment 4 plus webmaster and postmaster (as usually). 

Webmaster bounced, the rest was OK.

Comment 6

[Jacek Piskozub]

Second evangelism letter sent.

Comment 7

[Jacek Piskozub]

No progress. Futuring the bug.

Comment 8

[Bob Clary [:bc] (inactive)]

tech evang june 2003 reorg

Comment 9

[Marek Stępień [:marcoos, inactive]]

I've set up a temporarily corrected version of the page (see Jacek's comment 3) 
page at http://www.marcoos.zwm.punkt.pl/bugzilla/servisco/mapa.htm

Sent letter to:
[e-mail], [e-mail] and [e-mail].

Comment 10

[Marek Stępień [:marcoos, inactive]]

[e-mail] bounced.

Comment 11

[Marek Stępień [:marcoos, inactive]]

Site has been fixed and Jacek's modifications to dreamweaver's functions applied.

Checked with Netscape 7.1 and Firebird-trunk.

-> FIXED.