174242 - personal toolbar buttons shouldn't turn blue on active/hover

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just switched back to Classic after using Modern for close to a year, I think
(since the new look in modern in all the non-navigator windows (e.g., message
compose, mail) appeared), since I like the idea of native theme support.  And,
well, I found it nice, except for one jarring thing (which has always bothered
me).  The personal toolbar buttons turn blue when I hover over them.  That just
seems really odd/ugly UI, despite the fact that 4.x does it, and it certainly
doesn't mesh well with the native GTK look.

In any case, I'm filing this bug to propose that we change the :hover / :active
styles for personal toolbar buttons in the classic theme so that the text
doesn't turn blue when mousing over or clicking on the buttons or menus.  I'll
attach a simple patch.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm told jag now owns classic.

Comment 3

[jag (Peter Annema)]

Comment on attachment 102730 [details] [diff] [review]
patch

I deny everything. However, I like the underline, I'm fine with the blue going
away, so r=jag.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 102730 [details] [diff] [review]
patch

sr=bzbarsky

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-11-06 05:04 PDT.

Comment 6

[Patty Mac]

Verified on linux redhat 8.0 (netscape trunk build; 2002-12-06-08-TRUNK)

Comment 7

[Andreas Kunz]

This caused bug 181294 (see bug 181294 comment #3).