174690 - Remove the content-depth-limiting code on Unix platforms

Status: RESOLVED WONTFIX

(Core :: DOM: HTML Parser, defect, P5)

Description

[Boris Zbarsky [:bzbarsky]]

I was talking to Roland earlier today and he mentioned that we could use
"ulimit" in run-mozilla.sh to set the stack size to, essentially, 2GB on typical
Unix systems (32 bit, etc).  In particular,

ulimit -s unlimited

in run-mozilla.sh should do the trick.  The benefit is that we can probably stop
crippling the content model, which we do to avoid the stack-overflow issues in
layout....

So now we need to decide whether to do it.

Harish, I can't seem to locate the code that does this limiting.. Version 3.384
of nsHTMLContentSink.cpp has a checkin comment by you saying the code has moved
to the parser, but no bug# is included and there are no changes to CNavDTD.cpp
or nsParser.cpp around that date that seem immediately relevant...

Comment 1

[Henri Sivonen (:hsivonen)]

But is it truly useful if pages with badly nested font tags are allowed to
consume a lot of memory?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well... that's one aspect of it.  How much are we talking here?  iirc, we were
blowing out the stack with a few hundred kilobytes of stack-allocated data....

Comment 3

[harishd]

Check versions 3.309 and 3.360 of CNavDTD or search for MAX_REFLOW_DEPTH in CNavDTD.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Boris, is this something that you are still interested in? The fix would be
fairly simple if we wanted to do this.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I think it's still worth checking out, yes.  I guess one con is that it would
make rendering on Unix and Windows different...

Comment 6

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.

Comment 7

[Henri Sivonen (:hsivonen)]

The fix for bug 256180 is consistent across *nix and Windows.