174798 - Combobox's children are garbage

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Document content is showing up as the children of objects with ROLE_COMBOBOX.

For example, paragraphs and other form controls. The only children should be
options.

Comment 1

[Aaron Leventhal]

Attachment: Stop when parent is a <select>

Comment 2

[Aaron Leventhal]

Attachment: Testcase

Comment 3

[Aaron Leventhal]

Seeking r=kyle

Kyle, can you think of any reason we should keep the nsIDOMOListElement test? I
don't know why that was ever used.

Comment 4

[Kyle Yuan]

Attachment: My approach: check what we get from parent->GetNextSibling instead of the parent's type

I think this is better than enumerating black list here, but I can't verify my
patch due to bug 174949.
I have no idea about why nsIDOMHTMLOListElement is here.

Comment 5

[Aaron Leventhal]

Attachment: Testcase #2

A test case with <optgroup> and <!-- comment --> nodes sprinkled in

Comment 6

[Aaron Leventhal]

Attachment: Compares with node of parent accessible, and uses loop to avoid ending on comment or other non-accessible nodes

Kyle, when I saw your fix I realized that our code doesn't work when there are
comments in there.

Here's a new patch, seeking r=.

Comment 7

[Kyle Yuan]

Comment on attachment 103191 [details] [diff] [review]
Compares with node of parent accessible, and uses loop to avoid ending on comment or other non-accessible nodes

r=kyle

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 103191 [details] [diff] [review]
Compares with node of parent accessible, and uses loop to avoid ending on comment or other non-accessible nodes

sr=bzbarsky

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 103191 [details] [diff] [review]
Compares with node of parent accessible, and uses loop to avoid ending on comment or other non-accessible nodes

a=roc+moz for trunk

Comment 10

[Aaron Leventhal]

checked in

Comment 11

[dsirnapalli]

-- Verified in latest trunk(20021111). Works fine. Marking verified.