Closed Bug 175437 Opened 22 years ago Closed 22 years ago

[FIX]nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS()

Categories

(Core :: XPCOM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.2final

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Well, I finally got my "convert lots of people to nsCOMArray" build running and
ran into this cool threadsafety assertion on nsCOMArrayEnumerator.  Looks like
the problem is that this never calls NS_INIT_ISUPPORTS() in the constructor...

Good thing that we use mAutoRefCnt now, eh?
reviews?  I'd like to get this fixed before 1.2, for obvious reasons....
Priority: -- → P1
Summary: nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS() → [FIX]nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS()
Target Milestone: --- → mozilla1.2final
Blocks: 175440, 175442
isn't there a bug to get rid of NS_INIT_ISUPPORTS? yeah, bug 174225...
If that's landing for 1.2, good.  If not, we need this patch.
Comment on attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).

editor bet against it landing for 1.2. The person who fixes that bug can easily
remove any new instances of NS_INIT_ISUPPORTS().
Attachment #103437 - Flags: review+
> editor bet against it landing for 1.2

er?  what do you mean?
Clarification:  Comment 5 is a response to comments 3 and 4 and has nothing to
do with the real issue here.  ;) 
Comment on attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).

oops. heh.
sr=alecf
Comment on attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).

a=dbaron for trunk checkin
Attachment #103437 - Flags: superreview+
Attachment #103437 - Flags: approval+
fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: