Closed
Bug 175437
Opened 22 years ago
Closed 22 years ago
[FIX]nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS()
Categories
(Core :: XPCOM, defect, P1)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.2final
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
2.31 KB,
patch
|
timeless
:
review+
dbaron
:
superreview+
dbaron
:
approval+
|
Details | Diff | Splinter Review |
Well, I finally got my "convert lots of people to nsCOMArray" build running and ran into this cool threadsafety assertion on nsCOMArrayEnumerator. Looks like the problem is that this never calls NS_INIT_ISUPPORTS() in the constructor... Good thing that we use mAutoRefCnt now, eh?
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
reviews? I'd like to get this fixed before 1.2, for obvious reasons....
Priority: -- → P1
Summary: nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS() → [FIX]nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS()
Target Milestone: --- → mozilla1.2final
Assignee | ||
Updated•22 years ago
|
Comment 3•22 years ago
|
||
isn't there a bug to get rid of NS_INIT_ISUPPORTS? yeah, bug 174225...
Assignee | ||
Comment 4•22 years ago
|
||
If that's landing for 1.2, good. If not, we need this patch.
Comment on attachment 103437 [details] [diff] [review] patch (fixes some warnings too). editor bet against it landing for 1.2. The person who fixes that bug can easily remove any new instances of NS_INIT_ISUPPORTS().
Attachment #103437 -
Flags: review+
Assignee | ||
Comment 6•22 years ago
|
||
> editor bet against it landing for 1.2
er? what do you mean?
Assignee | ||
Comment 7•22 years ago
|
||
Clarification: Comment 5 is a response to comments 3 and 4 and has nothing to do with the real issue here. ;)
Comment 8•22 years ago
|
||
Comment on attachment 103437 [details] [diff] [review] patch (fixes some warnings too). oops. heh. sr=alecf
Comment on attachment 103437 [details] [diff] [review] patch (fixes some warnings too). a=dbaron for trunk checkin
Attachment #103437 -
Flags: superreview+
Attachment #103437 -
Flags: approval+
Assignee | ||
Comment 10•22 years ago
|
||
fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•