17558 - PR_Open() needs the unix equivalent of O_EXCL flag

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[larryh (gone)]

NSPR's PR_Open() function needs the equivalent of Unix's O_EXCL flag.

... Implementation for Netscape's Unix and Win32 platforms has been developed,
tested. It is waiting commit on implementations for MAC. ... Steve, can you
help?

Also, other platforms may want to implement similar capability (OS/2, BeOS).

Comment 1

[larryh (gone)]

Check in parts.
Note: MAC platform will be checked in by Steve Dagley after this checkin.

cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag" pr/tests/op_excl.c
RCS file: /cvsroot/mozilla/nsprpub/pr/tests/op_excl.c,v
done
Checking in pr/tests/op_excl.c;
/cvsroot/mozilla/nsprpub/pr/tests/op_excl.c,v  <--  op_excl.c
initial revision: 1.1
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/include/prio.h
Checking in pr/include/prio.h;
/cvsroot/mozilla/nsprpub/pr/include/prio.h,v  <--  prio.h
new revision: 3.18; previous revision: 3.17
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/src/md/unix/unix.c
Checking in pr/src/md/unix/unix.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/unix.c,v  <--  unix.c
new revision: 3.31; previous revision: 3.30
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"
pr/src/md/windows/ntio.c
Checking in pr/src/md/windows/ntio.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/ntio.c,v  <--  ntio.c
new revision: 3.15; previous revision: 3.14
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"
pr/src/md/windows/w95io.c
Checking in pr/src/md/windows/w95io.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/w95io.c,v  <--  w95io.c
new revision: 3.12; previous revision: 3.11
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/tests/Makefile
Checking in pr/tests/Makefile;
/cvsroot/mozilla/nsprpub/pr/tests/Makefile,v  <--  Makefile
new revision: 3.39; previous revision: 3.38
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/tests/ntioto.c
Checking in pr/tests/ntioto.c;
/cvsroot/mozilla/nsprpub/pr/tests/ntioto.c,v  <--  ntioto.c
new revision: 1.2; previous revision: 1.1
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/tests/runtests.ksh
Checking in pr/tests/runtests.ksh;
/cvsroot/mozilla/nsprpub/pr/tests/runtests.ksh,v  <--  runtests.ksh
new revision: 1.8; previous revision: 1.7
done

Comment 2

[larryh (gone)]

Checking in the MAC specific parts.
R: sdagley, larryh
Approved by chofmann

Checking in macio.c;
/cvsroot/mozilla/nsprpub/pr/src/md/mac/macio.c,v  <--  macio.c
new revision: 3.23; previous revision: 3.22
done

Comment 3

[larryh (gone)]

Fixed.

Comment 4

[Wan-Teh Chang]

The pthreads version did not get the PR_EXCL change.
I fixed this on the NSPRPUB_RELEASE_4_0_BRANCH.
/cvsroot/mozilla/nsprpub/pr/src/pthreads/ptio.c, revision 3.42.4.10

Comment 5

[Wan-Teh Chang]

Just wanted to acknowledge that Kurt J. Lidl <[e-mail]>
independently (and earlier than I did) fixed the PR_EXCL bug
in ptio.c.  He sent us a patch on 25 Jan 2000.