176084 - xpinstall/packager/makefile and pkgcp.pl updates

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Mike Kaply [:mkaply]]

These are the changes to get OS/2 using the Makefile in xpinstall/packager.

I'll explain in the diff

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Makefile updates

Pretty standard stuff.

OS/2 changes for packaging.

Change some parameters, as well as what is used for STRIP. also add code to
copy the C runtime so it gets packaged.

Also, we are a ZIP by default.

For VACPP, we change the TARGET_OS, since we default to os2-emx.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: pkgcp.pl updates

This one is a little stranger.

I added back support for using os2 when invoking pkgcp.pl, but only at the top
level. The reason I did this is because we have a PERL bug where the current
directory is getting changed arbitrarily. My fix was to mangle the paths we
pass to Packager.pm to be fully qualified. We only do this in the OS/2 case,
and then we change the OS to Unix.

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 103759 [details] [diff] [review]
Makefile updates

r=cls

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 103760 [details] [diff] [review]
pkgcp.pl updates

r=cls

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin for both patches.

Comment 6

[Mike Kaply [:mkaply]]

Fixes checked in.

I made a small change to the pkgcp.pl one - I only prepend the path if the
second character is not already a :

This allows fully qualified paths to work.

Comment 7

[K'Trina Medina]

Verified code fix