177363 - Add Text Style to Context Menu in Composer

Status: RESOLVED WONTFIX

(SeaMonkey :: Composer, enhancement)

Description

[Chris Shaffer]

To reduce the number of 'mouse miles', it would be nice to have the 'Text Style'
sub menu as part of the Context Menu when Text is selected.

Comment 1

[Chris Shaffer]

Reassinged to myself ([e-mail])

Comment 2

[Chris Shaffer]

Attachment: Patches chrome/comm.jar for Text Style in context Menu

I was not really sure what format I should have provided this 'patch' in.  I
archived the two files I changed into comm_Patch.jar.  The two files in the my
archive are:
content/editor/EditorContextMenuOverlay.xul
content/editor/EditorContextMenu.js

These file replace the files of the same name in chrome/comm.jar.  If I need to
provide this patch in another format, please email me and let me know.

Changes in "EditorContextMenuOverlay.xul"
-----------------------------------------
Added menu "fontStyleMenu_cm" to popupset "editorContentContextSet"

Changes in "EditorContextMenu.js"
-----------------------------------------
Added function call to SetElementEnabledById to enable Text Style sub menu if
object selected is NOT an image.

Comment 3

[Chris Shaffer]

Attachment: Applies 'Text Style' Menu to Context menu in editor

Added call to SetElementEnabledById to enable menu item 'fontStyleMenu_cm' if
object selected was NOT an image.

Comment 4

[Chris Shaffer]

Attachment: Added tags to add Text Style Menu to Context Menu in Editor

Added tags for the 'Text Style' menu item to be added to the Context Menu with
in editor.  

Menu item added was 'fontStyleMenu_cm'.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

cmanske: could you take a look at this "patch" and review it?

reporter: please attach a patch in patch format, by using "cvs diff -u >
name_of_patch_file" if you are using CVS.

Comment 6

[Chris Shaffer]

Attachment: EditorContextMenu.js - Inculdes edits to enable Text Styles in Context Menu

Applied edit to current CVS version of file to add 'Text Style' submenu to the
Context menu in Composer.  Used call to SetElementEnabledById() to enable the
submenu if objext selected was NOT an image

Comment 7

[Chris Shaffer]

Attachment: EditorContextMenu.js.dif - Difference between modded version and CVS version

'cvs diff -U EditorContextMenu.js' output

Comment 8

[Chris Shaffer]

Attachment: EditorContextMenuOverlay.xul - added tags for Text Styles Submenu

Added tags to add 'Text Style' to Context menu in Composer

Comment 9

[Chris Shaffer]

Attachment: EditorContextMenuOverlay.xul.dif - Diff b/w local copy and CVS version

'cvs diff -U EditorContextMenuOverlay.xul' output

Comment 10

[Sören 'Chucker' Kuklau (gone)]

Reporter, there is no need for attaching the whole document. Just attach one
patch with the changes to both files, and mark it "patch".

Maybe someone should CONFIRM this bug? I won't :-D

Comment 11

[Charles Manske]

I'm not so sure this is a good idea! Context menus are crowded already. 
Brade?

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I disagree with having this in the contextual menu. What we should have instead is
(un)dockable menus.

I recommend a WONTFIX for this bug.

Comment 13

[Chris Shaffer]

You do acculate alot of 'mouse miles' by having to back through the menu system
to get to some type of special style (like CODE...)  Perhaps a drop down list on
the toolbar would work...  I'll try that...

Comment 14

[Asa Dotzler [:asa]]

per Glazman, wontfix.