17767 - [FEATURE] Tasks menu implementation

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[daver]

The Tasks menu has the following items:

     Navigator
     Mail
     Instant Messenger
     Security Advisor
     Composer
     ------------------
     Address Book
     Newsgroup
     -------------------
     Tools

According to German:

"Hi Dave:
Agree, the Menu Framework specification for 5.0 specifically mentions Security
to be a menu item in the Tasks menu, but in poisition
much lower than what you describe:

Navigator
Mail
Instant Messenger
Address Book
------------------------
Services A  >
Services B  >
Services C  >
Services D  >
------------------------
Services E  >
Services F  >
Services G >
Services H  >
------------------------
Security Info   Shift-I
------------------------
Tools  >
------------------------
Go To Window  >

Where did you find this?
+ G "

Comment 1

[Michael La Guardia]

Changing Summary from "[beta] Security Advisor should move down in task menu" to
"[beta] need final task menu implementation".  Reassigning to German.  I agree
with the email from German that Dave copied into the bug.

Comment 2

[german]

Don: we need help with implementing this menu as spec'd. Who is working on the
corss-app menus these days? I assume Matt would be the right person?

Comment 3

[hangas]

This was being handled by davidm.  I am guessing it still is.

Comment 4

[don]

Hmmmm ...

Comment 5

[don]

Matt ...

Comment 6

[don]

*** Bug 15100 has been marked as a duplicate of this bug. ***

Comment 7

[Ninoschka Baca]

Reminder to nbaca to check 15100 when this bug is fixed.

Comment 8

[sairuh (rarely reading bugmail)]

several of the Task items are in my realm. reassigning qa contact to me.

Comment 9

[don]

Chris, you are now the proud owner of the task menu/switcher for beta 1.  Aren't
you the lucky one.

Comment 10

[don]

The task menu/switcher has to work for beta and contain the correct items. 
Nominating as a "beta1" blocker.

Comment 11

[johng]

Also see bug 24121 which details what we are doing for beta 1 in the Task Bar.
 
Getting everything right in this menu is not as critical as the Task Bar - 
Netcenter expects the Task Bar but is less worried about the menu for beta 1.  
We just need to make sure that this menu doesn't "suck".

This doesn't have to be a beta 1 blocker, but it should remain M14.

Comment 12

[johng]

removed Don's beta1 nomination - Don OKed that.

Comment 13

[bijals (gone)]

If Net2Phone is installed on the end user's machine, a TASK menu item for 
Net2Phone should be placed in the 2nd group where the Address Book is listed.  
List Net2Phone as the last component in this group.

Comment 14

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 15

[Chris McAfee]

m15

Comment 16

[don]

Move to M16 for now ...

Comment 17

[sairuh (rarely reading bugmail)]

nominating for beta2 --however, i'm not even sure what the "must haves" are for
this menu. anyone? bueller?

Comment 18

[leger]

Putting on [nsbeta2+][6/15] radar.

Comment 19

[don]

Move to M19 target milestone.

Comment 20

[Claudius Gayle]

I guess it's about time we fixed these up to look exactly like they're supposed to. Johng and German, I can't find specs for this 
stuff that have been updated since 00:00 Jan 1, 1970 (that's what the dates say :-), could you point some out? While you're at it 
specs for the taskbar(separate bug) would be cool too as I think things have shifted a little since PR1.

Comment 21

[johng]

Assigning to German for input on what this menu should say

Comment 22

[Jim Roskind]

Cleaning up status whiteboard by marking beta2 minus (6/15 has psssed)

It sonuds like we need a spec to work towards... and I'm sure folks are too 
doomed to change much of this for beta2

Comment 23

[johng]

nsbeta3 to keep on radar.  Important polish issue.

Comment 24

[german]

JohnG I assume this is fixed - right?. Right the Tasks menu is implemented 
according to spec, except we have now a submenu "Privacy and Security" as decided 
elsewhere, as well as we decided to simply appending the list of windows to the 
last section of Tasks menu instead of having another submenu in order to make 
them more discoverable. Marking worksforme. Please reopen if you see the need or 
file new bug if we need to change/amend other stuff.

Comment 25

[jglick]

Attachment: Task Menu

Comment 26

[Claudius Gayle]

I'm reopening the bug. Show me the spec. Currently, there are 3 implementations: The one outlined in this bug originally, the 
one in the recent attachment, and the one in the builds :-/. Also, the attachement and German's most recent comments 
contradict each other.

Comment 27

[johng]

nav triage team:
nsbeta3+, P1
the current implementation is correct except that we need to add a link for
"Download" ...  German will clarify.

Comment 28

[Matthew T (active 1999-2002)]

This looks like a job for Timeless ...

For the record, the current implementation is: (as far as I can tell, coz 
Messenger is missing from the latest build for some reason)

Tasks
-----
  Navigator
  Messenger
  Composer
  Chatzilla
-------------------------
  Address Book
  Newsgroups
-------------------------
  Privacy and Security  > [hideously complicated submenus here -- see bug 48860]
------------------------- ______________________
  Tools                 >|  History             |
-------------------------|  Import Utility      |
  {list}                 |  Java Console        |
  {of}                   |  JavaScript Console  |
  {open}                  """"""""""""""""""""""
  {windows}

Obvious problems with this:

* Bookmarks aren't present, meaning that there is no way to open the Bookmarks
  window from a non-Navigator window (bug 44524).

* The latest attachment shows `Auto-fill form', but that has been moved to the
  Edit menu (bug 42438, bug 48986). Meanwhile, I've just asked that `Forms
  Manager' be given its own main menu item, since it's really got nothing to do
  with privacy and security.

  Since the latter would just be taking up the real estate abandoned by the
  former, I assume there would be no objection to this? Please annotate bug 50494
  accordingly.

* `Import Utility' should be named by what it does, not what it is, i.e.
  `Import/Export ...'

* Too many menu separators.

Comment 29

[timeless]

Yes I can do everything except the following two mirracles:
a) Get german to make the spec reasonable (or change the spec at all)
b) Change the api.
Currently xul allows absolute positioning.  This is not a good idea.

Assuming I want something near:
-------------------------
  Address Book
<--here-->
-------------------------

I can guess that the number 6 is ok for positioning

My current menu has:
Nav
Mail
Comp
-
Addr
6-
7IRC Chat [as you can see Chatzilla is already suffering because of this 
feature absense]
Someone else might have:

Nav
-
<nothing>
-
Privacy And Security
-
Tools
7IRC Chat

Until we change the api to be sane I can't truely fix all of the problems to 
match the requested spec.

Hi Ben, I'm sure you know who should address the insertion issues. Please CC 
them w/ comment.

For the moment, I think I could use java script to get the id's of the 
separators, and insert after them.
--
Alternative:
We use multiple <menupopup><!--s--></menupopup> For the tasks menu, And just 
combine them using some JS glue [The overlay writers specify which tasks menu 
they want to put something in], this solves the location functionality very 
easily and cleanly (except for js glue). 

Example:
<menu id="taskPopup" onload="compositeTaskPopup()">
<menupopup id="appSuite">
<menu id="navi" value="Navigator">
</menupopup>
<menupopup id="appExtras">
<menu id="adbk" value="Address Book">
</menupopup>
<menupopup id="appPSM">
<menu id="psm" value="Privacy and Security">
</menupopup>
<menu id="tools"/>
<menupopup id="appWindows"/>
</menu>

By default a separator will appear before and after each menupopup (except 
where it would be the first or last item in the menu).

Actually this proposal solves problems in File>New> and probably elsewhere.  If 
I can get the glue working I'll attach a demo patch.

Blake what do you think?
--
I also have a bunch of problems with the spec.

German I now have CVS. I'm going to make changes to the spec according to a 
proposal I sent you months ago.  If you have objections please send them to me 
w/in the week.

Hi Brendan. German is unresponsive. I'll forward a copy of my proposed changes.

Comment 30

[leger]

PDT does not see what is critical to do here?  Looks like low profile polish.  
Moving to P3.  Adding [PDTP3]

Comment 31

[Karl Johan Kleist]

(Cosmetics only, but anyhow... )

Also, selecting the "Address Book" item if the mail component is not installed
does nothing. I guess it should not be rendered at all, or at least disabled?

Comment 32

[timeless]

I have worked on this and am almost ready to give it to people, my solution 
would also work for File>New>.

If I don't attach the patch to this bug by wednesday, someone should nag me.

Comment 33

[Simon Fraser [no longer active]]

timeless: some comments.
You need to add new files to makefile.win, makefile.mk, MANIFEST, and jar.mn 
files. It also needs to be verified that this works in the netscape commercial 
build.

IMHO this is too risky for nsbeta3.

Comment 34

[Simon Fraser [no longer active]]

cc self

Comment 35

[johng]

As of today, the first level of the menu on the commercial build looks fine with
2 possible changes.

Commerical build today (build 2000091408)looks like this:

Tasks:

- Navigator   Ctrl+1
- Mail      Ctrl+2
- Instant Messenger  Ctrl+3
- Composer   Ctrl+4
- Address Book   Ctrl+5
---------------------
- Net2Phone
- Privacy and Security >
---------------------
- Tools
---------------------
(session history list)

SUB MENUS:

Privacy and Security >
- Secuirty Manager
- Password Manager >
- Form Manager >
- Cookie Manager >
-----------------
- Understanding Privacy

All of this, and the details within the sub-folders, is currently correct with 2
possible exceptions:

1)  The link to "Understanding Privacy" appears to be pointing to the wrong
document.  See bug 52674
2)  We need to add an item to this menu, specifically "Download" and this should
immediately follow "Tools" before the separator.  The url should be the
following:  http://home.netscape.com/bookmark/6_0/tdownload.html

Comment 36

[timeless]

- Address Book   Ctrl+5
---------------------
- Net2Phone
- Privacy and Security >

That's wrong.

Net2Phone should not be near P&S.

Comment 37

[Chris McAfee]

I was unable to guarantee the menu item positions because
we can only specify absolute position of menu items (I think).
Specifically, AIM in the #3 slot pushes other elements down
but does NOT push them down for mozilla, so the absolute insertion
point is a moving target and makes Task menu ordering non-deterministic.
If we could use relative positioning or some dummy element
mechanism, that would be good.  Hyatt or ben?

Comment 38

[german]

Just to clarify the Netscape Task menu is supposed to look like this:

Navigator                     

Mail 

Instant Messenger

Composer

Address Book

---------

Net2Phone

Other installed components (like Chatzilla or ThemeBuilder)

---------

Privacy and Security    >

 Tools      > 

----------

Open Window 1

Open Window 2

...

Open Window n



This is also what McAfee had attempted to do, but as he describes the 

ordering problem was such that this could not be accomplished easily. 

The bug goes to Ben (cc'ing Hyatt) because either one of this guys might 

know of mighter ways to insert menus other than the above mentioned 

absolute positioning.                            

Comment 39

[timeless]

I have a method that'd work, but it'd be to do some javascript sorting on a non 
rendered popupmenu before inserting into the real menu. I'll look into this 
shortly.

Comment 40

[Ben Goodger (use ben at mozilla dot org for email)]

It is impossible to force add on applications to occupy a given range. An add 
on, such as chatzilla, mailnews, AIM etc may insert any nodes it pleases into 
any node with an ID, at any index. 

What specifically is going wrong? 

Comment 41

[don]

Temporarily elevating to P2.

Is this a stop ship bug?  Do we want to move it to RTM?

Comment 42

[timeless]

I had a recommended implementation for this, but I think mozilla killed my 
computer while i was distracted and had not submitted, i'll write the 
recommendation and proposed patch tonight.

sfraser: it'll be based on that code I asked you to check, so I need to know if 
that code worked on macos.

Comment 43

[Phil Peterson]

PDT thinks this is an nsbeta3- at this point. If you renominate for RTM, please
resummarize the critical issue at hand.

Comment 44

[Matthew T (active 1999-2002)]

[resummarizing so this bug is easier to find]

Comment 45

[Chris McAfee]

yeah id's might work.
Since this is coming in from a (possibly) commercial overlay,
we might want to have generically-named menu id stubs.

Comment 46

[Ben Goodger (use ben at mozilla dot org for email)]

There is no M19

Comment 47

[Matthew T (active 1999-2002)]

There is no further feature work in mozilla0.6, either. Assume you meant 
mozilla0.9.

Comment 48

[Ben Goodger (use ben at mozilla dot org for email)]

What is wanted here, again? Trying to prune my .9 list of non-bookmarks related 
tasks. 

Comment 49

[Matthew T (active 1999-2002)]

See also bug 32502.

Comment 50

[Ben Goodger (use ben at mozilla dot org for email)]

out we go. 

Comment 51

[Zach Lipton [:zach]]

Chaning the qa contact on these bugs to me. MPT will be moving to the 
owner of this component shortly. I would like to thank him for all his hard 
work as he moves roles in mozilla.org...Yada, Yada, Yada...

Comment 52

[Blake Ross]

What is still needed here?  Ben has asked a few times, with no answer.  
Closing, file new bugs for specific issues.

Comment 53

[timeless]

the problem reported here is that (a) our implementation doesn't match the 
spec and (b) items tend to land out of their ranges [examples of things that 
fall incorrectly include chatzilla and some commercial items]. it has been 
mentioned that we now have insertafter and insertbefore which should probably 
work to fix this bug.

I've seen relatively recent reports of (b) so i'd say it isn't fixed. but 
whatever.