178368 - No need to store HTML references in search graph if in default/simple mode

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Robert John Churchill]

No need to store HTML references in search graph if in default/simple mode as
HTML chunks aren't displayed in UI. This will significantly reduce memory
footprint for storing search results.

Comment 1

[Robert John Churchill]

Attachment: Patch

Samir, care to review?

Comment 2

[Samir Gehani]

Comment on attachment 105139 [details] [diff] [review]
Patch

r=sgehani

Comment 3

[jag (Peter Annema)]

Comment on attachment 105139 [details] [diff] [review]
Patch

>Index: mozilla/xpfe/components/search/src/nsInternetSearchService.h
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/components/search/src/nsInternetSearchService.h,v
>retrieving revision 1.15
>diff -i -u -4 -r1.15 nsInternetSearchService.h
>--- mozilla/xpfe/components/search/src/nsInternetSearchService.h	19 Jun 2002 00:50:20 -0000	1.15
>+++ mozilla/xpfe/components/search/src/nsInternetSearchService.h	5 Nov 2002 01:17:04 -0000
>@@ -60,8 +60,9 @@
>                                  public nsSupportsWeakReference
> {
> private:
>   static PRInt32          gRefCnt;
>+  static PRInt32          mBrowserSearchMode;
>   static PRBool           mEngineListBuilt;

These should be g*, not m*.

You may also want to initialize gBrowserSearchMode (and perhaps
gEngineListBuilt?).

sr=jag with that changed.

Comment 4

[Robert John Churchill]

Fixed.