178440 - [mach] Mach-0 mozilla ignores startup prefs

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect)

Description

[Conrad Carlen (not reading bugmail)]

Mozilla only enumerates the general.startup.* prefs (those set in the prefs UI)
if the program receives the default number of args. "Default" is considered to be 1.
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsAppRunner.cpp#1470
But the Mach-0 build, if double-clicked from the Finder, is passed 2 args so we
don't read these prefs.

Comment 1

[Conrad Carlen (not reading bugmail)]

Taking.

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: patch

This fixes it on 10.2. Can anybody with a 10.1 system test whether we get
passed the psn arg on 10.1 as well?

Comment 3

[Steve Dagley]

Comment on attachment 105192 [details] [diff] [review]
patch

r=sdagley (ccarlen and I discussed the PSN compare and he's convinced me the
sprintf is less overhead than a scanf)

And verified this will work on 10.1 as we get 2 args there with the 2nd being
the PSN

Comment 4

[Simon Fraser [no longer active]]

Comment on attachment 105192 [details] [diff] [review]
patch

sr=sfraser

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 105192 [details] [diff] [review]
patch

a=asa for checkin to the 1.2 branch (on behalf of drivers).

Comment 6

[Conrad Carlen (not reading bugmail)]

Checked into 1.2 branch.

Comment 7

[sairuh (rarely reading bugmail)]

out of curiosity, should this be checked into the trunk as well? (unless you
already did so earlier. :)

Comment 8

[Conrad Carlen (not reading bugmail)]

It went into the trunk already.

Comment 9

[sairuh (rarely reading bugmail)]

okay, good.

rs vrfy (checked lxr) with 2002.11.18.14 (trunk, mach-o).