Closed Bug 179361 Opened 22 years ago Closed 22 years ago

fix shutdown leaks in gtk port

Categories

(Core Graveyard :: GFX, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.3alpha

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: memory-leak, Whiteboard: [patch])

Attachments

(2 files)

I have a fix for a bunch of one-time leaks in the GTK port.  Not that useful,
but less noise in the leak stats, and useful if someone embeds Mozilla for part
of the lifetime of an app (or, for some fixes, restarts it in-process).

These need a little cleaning up, still, and I need to do a little more testing
on some of them that they're really correct.
Status: NEW → ASSIGNED
Keywords: mlk
Priority: -- → P4
Target Milestone: --- → mozilla1.3alpha
Regarding the nsAppShell -- is there only one?  If so, why not use member
variables rather than global variables?
Comment on attachment 105748 [details] [diff] [review]
patch v. 1

r=blizzard

I think there can be multiple appshells, so be careful.  It's not a service.
Attachment #105748 - Flags: review+
Comment on attachment 105748 [details] [diff] [review]
patch v. 1

I replaced the unconditional call to PL_DHashTableFinish with:

  if (gXICLookupTable.ops) {
    PL_DHashTableFinish(&gXICLookupTable);
    gXICLookupTable.ops = nsnull;
  }
Attachment #105748 - Flags: superreview?(bryner) → superreview+
Fix checked in, 2002-11-12 19:01 PDT.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
The leak stats didn't show any effect from the gdk_font_unref and
gdk_widget_unref changes.  I need to investigate that...
Actually, it was just the fontset objects.  The gtkinvisible leak fix did show
up in the leak stats.
I did miss one, though, and I'm going to be lazy and reopen this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #106509 - Flags: superreview?(bryner)
Attachment #106509 - Flags: review?(blizzard)
Comment on attachment 106509 [details] [diff] [review]
additional patch

r=blizzard
Attachment #106509 - Flags: review?(blizzard) → review+
Attachment #106509 - Flags: superreview?(bryner) → superreview+
Fix checked in, 2002-11-21 07:22 PDT.
Status: REOPENED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: