Closed
Bug 179361
Opened 22 years ago
Closed 22 years ago
fix shutdown leaks in gtk port
Categories
(Core Graveyard :: GFX, defect, P4)
Core Graveyard
GFX
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3alpha
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: memory-leak, Whiteboard: [patch])
Attachments
(2 files)
9.27 KB,
patch
|
blizzard
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
686 bytes,
patch
|
blizzard
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
I have a fix for a bunch of one-time leaks in the GTK port. Not that useful, but less noise in the leak stats, and useful if someone embeds Mozilla for part of the lifetime of an app (or, for some fixes, restarts it in-process). These need a little cleaning up, still, and I need to do a little more testing on some of them that they're really correct.
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Assignee | ||
Updated•22 years ago
|
Whiteboard: [patch]
Assignee | ||
Comment 2•22 years ago
|
||
Regarding the nsAppShell -- is there only one? If so, why not use member variables rather than global variables?
Comment 3•22 years ago
|
||
Comment on attachment 105748 [details] [diff] [review] patch v. 1 r=blizzard I think there can be multiple appshells, so be careful. It's not a service.
Attachment #105748 -
Flags: review+
Assignee | ||
Comment 4•22 years ago
|
||
Comment on attachment 105748 [details] [diff] [review] patch v. 1 I replaced the unconditional call to PL_DHashTableFinish with: if (gXICLookupTable.ops) { PL_DHashTableFinish(&gXICLookupTable); gXICLookupTable.ops = nsnull; }
Assignee | ||
Updated•22 years ago
|
Attachment #105748 -
Flags: superreview?(bryner)
Updated•22 years ago
|
Attachment #105748 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 5•22 years ago
|
||
Fix checked in, 2002-11-12 19:01 PDT.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•22 years ago
|
||
The leak stats didn't show any effect from the gdk_font_unref and gdk_widget_unref changes. I need to investigate that...
Assignee | ||
Comment 7•22 years ago
|
||
Actually, it was just the fontset objects. The gtkinvisible leak fix did show up in the leak stats.
Assignee | ||
Comment 8•22 years ago
|
||
I did miss one, though, and I'm going to be lazy and reopen this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Attachment #106509 -
Flags: superreview?(bryner)
Attachment #106509 -
Flags: review?(blizzard)
Comment 10•22 years ago
|
||
Comment on attachment 106509 [details] [diff] [review] additional patch r=blizzard
Attachment #106509 -
Flags: review?(blizzard) → review+
Updated•22 years ago
|
Attachment #106509 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 11•22 years ago
|
||
Fix checked in, 2002-11-21 07:22 PDT.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•