17956 - [DOGFOOD] reply to message in Local Mail, and you get no body

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

reply to message under a pop server and it works.

reply to a message under local mail, and it fails.

I'll look into it tomorrow.

Comment 1

[(not reading, please use [e-mail] instead)]

could be a problem caused by the fact the uri would be

mailbox://nobody@Local Mail/Trash#4

Comment 2

[(not reading, please use [e-mail] instead)]

yes, it looks like it's caused by the space.

when I change (in my prefs and on disk) "Local Mail" to "LocalMail" reply works.

debugging to find out where the space kills us now...

accepting.

Comment 3

[lchiang]

alec has a bug or two about the space problem in Local Mail.  I don't think
those bugs mention this reply/quote case though.

Comment 4

[(not reading, please use [e-mail] instead)]

since imap, nntp, and pop3 work, but the none (aka Local Mail) case fails, and
this is less common, moving this to m12, and not m11.

not a stopper for m11.

Comment 5

[lchiang]

I agree for the target milestone of M12.  If someone was using 4.x POP and
migrated, would their POP folders be migrated into local mail?

Comment 6

[(not reading, please use [e-mail] instead)]

no, if they used pop in 4.x, they would not have this problem.

local folders (when using pop) go into something like

<profile>/Mail/<servername>/Trash

Comment 7

[(not reading, please use [e-mail] instead)]

ok, here's the problem.

in nsMsgComposeService.cpp, line 240, we are passing null for object to

msgCompose->Initialize(aWindow, originalMsgURI, type, format, compFields,
object, identity);

the reason it's null is because at in nsMsgComposeService.cpp, line 228
we compare  hack_uri[i] to originalMsgURI.

hack_uri[i] is mailbox_message://nobody@Local%20Mail/Trash#4
and originalMsgURI is mailbox_message://nobody@Local Mail/Trash#4

so the compare fails.  one possible solution is to URL escape before comparing.

comments?

    	/*--- temporary hack ---*/
    	    int i;
    		nsISupports * object = nsnull;
    	    if (originalMsgURI)
    		    for (i = 0; i < 16; i ++)
    		    	if (hack_uri[i] == originalMsgURI)
    		    	{
    		    		hack_uri[i] = "";
    					object = hack_object[i];
    					hack_object[i] = nsnull;
    					break;
    				}
    	/*--- temporary hack ---*/

Comment 8

[rhp (gone)]

Hi JF,
Does this one ring a bell?

- rhp

Comment 9

[Jean-Francois Ducarroz]

All this hack stuff should go away. We normally don't need it anymore as we can
retreive message data from the URI now. I will take a look at remove it and
converting necessary code. Reassign it to me please

Comment 10

[Jean-Francois Ducarroz]

OK, I have removed the hack in my build and reply still working fine. I haven't
tested yet for local mail but I am pretty sure it will works.

Comment 11

[(not reading, please use [e-mail] instead)]

send me your patch so I can test it.

Comment 12

[Jean-Francois Ducarroz]

Attachment: Fix Patch

Comment 13

[Jean-Francois Ducarroz]

Seth, the patch is here (id=2629). Could you review it? thanks

Comment 14

[(not reading, please use [e-mail] instead)]

jfd, I'm having troubles getting and applying your patch.

can you send it to me via email?

Comment 15

[Alec Flett]

seth -
setenv POSIXLY_CORRECT 1

before applying the patch, I often have that problem.

Comment 16

[Jean-Francois Ducarroz]

patch sent by email

Comment 17

[(not reading, please use [e-mail] instead)]

jfd, your changes look good, and they fix this bug.

check it in!

Comment 18

[Jean-Francois Ducarroz]

That solve also bug 8510. I like solving bugs by removing codes...

Comment 19

[leger]

Putting on PDT+ radar.

Comment 20

[(not reading, please use [e-mail] instead)]

seeking approval to check this in now...

Comment 21

[(not reading, please use [e-mail] instead)]

marking m11...awaiting for approval now...

Comment 22

[(not reading, please use [e-mail] instead)]

I just checked in ducarroz's fix.  marking fixed.

Comment 23

[esther]

Using build 1999111017 on win and linux and 1999111011 on mac when I click Reply
to a message in a Local Mail folder, the compose window comes up but the reply
to address is not filled in nor is the title of the message visible on the
subject line after  Re:   Since this bug was for the body missing this is fixed
- I will verify it and a new bug will be logged (18620).  Note: If I fill in an
address (one that is not what should have been automatically entered) and send
it goes to the address I entered only (meaning the address is missing not just
invisible).

Comment 24

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/1af893c00096
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17956: Add top site telemetry to available search engines (https://github.com/mozilla-mobile/fenix/pull/18129)