179579 - Addtional support - nsIJar.idl

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Doug Turner (:dougt)]

I would like to expose the number of signed items a jar has via the nsIJar
interface.  This is so that I can verify that a jar does not have any missing files.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Mitchell Stoltz (not reading bugmail)]

Comment on attachment 105883 [details] [diff] [review]
patch v.1

Your mTotalItemsInManifest counter will be incremented on manifest entries with
no name, and on duplicate entries. That may be what you want. If not, you
probably want to move the increment below the if-clauses that set JAR_INVALID,
then test for JAR_INVALID before incrementing.

Aside from that, r=mstoltz.

Comment 3

[Doug Turner (:dougt)]

that is exactly what I want.  Thanks for the quick review mitch!

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 105883 [details] [diff] [review]
patch v.1

I believe all this is rolled into the big signed-xpi patch I'm reviewing, but
sr=dveditz here anyway

Comment 5

[Doug Turner (:dougt)]

Checking in nsIJAR.idl;
/cvsroot/mozilla/modules/libjar/nsIJAR.idl,v  <--  nsIJAR.idl
new revision: 1.10; previous revision: 1.9
done
Checking in nsJAR.cpp;
/cvsroot/mozilla/modules/libjar/nsJAR.cpp,v  <--  nsJAR.cpp
new revision: 1.99; previous revision: 1.98
done
Checking in nsJAR.h;
/cvsroot/mozilla/modules/libjar/nsJAR.h,v  <--  nsJAR.h
new revision: 1.42; previous revision: 1.41
Checking in objs.mk;
/cvsroot/mozilla/modules/libjar/objs.mk,v  <--  objs.mk
new revision: 1.4; previous revision: 1.3
done