179638 - Security group inclusion isn't indicated on "New:" notification

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Jacob Steenhagen]

The email sent to me by bugzilla when Bug 179491 didn't indicate that this bug
was in the Webtools group.  I think it should.

Comment 1

[Jacob Steenhagen]

I should probably learn how to type... I meant when bug 179491 /was filed/. 
Also, I'm not really sure if this is as a result of the groups re-write or if
it's been a long existing problem.

Comment 2

[Joel Peshkin]

Bugmails have never indicated group settings.  Note, in particular, that there
is nothing special about the security group (it is just a group).  If you look
at bug 147275, it is now becoming possible to make a group special.  This would
be an enhancment.  How would we want such a thing to behave?

Comment 3

[Michael Lefevre]

*** Bug 231401 has been marked as a duplicate of this bug. ***

Comment 4

[Dave Miller [:justdave]]

Any non-mandatory group ought to be listed in the new bug notification.

Comment 5

[Frédéric Buclin]

this is probably something we want for 2.24. CC'ing wicked and bkor who may be interested in fixing this one.

Comment 6

[Frédéric Buclin]

This bug is retargetted to Bugzilla 3.2 for one of the following reasons:

- it has no assignee (except the default one)
- we don't expect someone to fix it in the next two weeks (i.e. before we freeze the trunk to prepare Bugzilla 3.0 RC1)
- it's not a blocker

If you are working on this bug and you think you will be able to submit a patch in the next two weeks, retarget this bug to 3.0.

If this bug is something you would like to see implemented in 3.0 but you are not a developer or you don't think you will be able to fix this bug yourself in the next two weeks, please *do not* retarget this bug.

If you think this bug should absolutely be fixed before we release 3.0, either ask on IRC or use the "blocking3.0 flag".

Comment 7

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?". Then, either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

This particular bug has not been touched in over eight months, and thus is being retargeted to "---" instead of "Bugzilla 4.0". If you believe this is a mistake, feel free to retarget it to Bugzilla 4.0.

Comment 8

[Mike Durthaler]

Is this already a done deal?  Also, with 3.2 being frozen 2 months agot, is the freeze now lifted?  Just checking to make sure this is still an open issue as it was first reported in 2002.

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

I too get "New" emails for the security group because I "watch" [e-mail], which is implicitly on the CC list of security 
mails, and I too wish there was something in those emails on which I 
could filter so that those security emails would go into a folder where
they'd be treated with the appropriate level of attention.  

I can think of at least two ways to do that.
1. Put a new indicator in the mail, showing the value of the group "flag".
2. At the bottom of the email, where it says 
   "You are receiving this email because:"
   "You are watching someone on the CC list of the bug."
change "someone" to the particular email address(es) being watched.

Comment 10

[Nelson Bolyard (seldom reads bugmail)]

I meant "implicitly on the CC list of security *bugs*", of course. :(

Comment 11

[Reed Loden [:reed]]

(In reply to comment #9)
> I too get "New" emails for the security group because I "watch"
> [e-mail], which is implicitly on the CC list of security 
> mails, and I too wish there was something in those emails on which I 
> could filter so that those security emails would go into a folder where
> they'd be treated with the appropriate level of attention.

X-Bugzilla-Watch-Reason: CC [e-mail]

That should already exist... Does that address your need?

Comment 12

[Nelson Bolyard (seldom reads bugmail)]

In reply to comment 11,
Yes, I think it does.  Thanks Reed.

Comment 13

[Teemu Mannermaa (:wicked)]

Attachment: Enable groups in new bugmail, V1

This simply enables group information on new bugmail notifications. But am I missing some group related security or other strangeness that should be taken into consideration here?

Comment 14

[Max Kanat-Alexander]

Comment on attachment 349538 [details] [diff] [review]
Enable groups in new bugmail, V1

>Index: Bugzilla/Install/DB.pm
>+    # Bug 179638
>+    $dbh->do("UPDATE fielddefs SET mailhead = 1 " .
>+             "WHERE name = 'bug_group'");

  This is unnecessary (Bugzilla::Install already does this for you). Otherwise, everything is fine. Just remove this part on checkin.

  -Max

Comment 15

[Frédéric Buclin]

Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.124; previous revision: 1.123
done
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
new revision: 1.40; previous revision: 1.39
done

Comment 16

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.