180623 - Add Date & Time for started (or added) download

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, enhancement)

Description

[Nicolas Miceli]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115

Following bug 148650, Mozilla should record date and time a download has been
started, and have a corresponding column in Download Manager for better
organizing downloads.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Pham]

Would be good, but we already have time elapsed/past and if you knew math you
could figure out when you started.

I wouldn''t even care when I started.

Comment 2

[Nicolas Miceli]

This is not about math. Pham.

It would give a the user a clue about when he downloaded what.

Time elapsed is a totally different thing. Try sorting all your downloads with
that column, a you have nothing usefull in your hands.

Comment 3

[Ian Neal]

*** Bug 193374 has been marked as a duplicate of this bug. ***

Comment 4

[Matthias Versen [:Matti]]

*** Bug 207598 has been marked as a duplicate of this bug. ***

Comment 5

[Patrick]

*** Bug 209156 has been marked as a duplicate of this bug. ***

Comment 6

[Matthias Versen [:Matti]]

*** Bug 212812 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 213579 has been marked as a duplicate of this bug. ***

Comment 8

[Matthias Versen [:Matti]]

*** Bug 213697 has been marked as a duplicate of this bug. ***

Comment 9

[Andy Gerweck]

I've just added my vote for this bug.  I'm tempted to call it a bug instead of
an enhancement since it really is a core part of what makes a download manager
useful.  Adding "Time Started" and "Time Finished" columns should be pretty easy.

I'd suggest including the start time by default as well.  This would really be
useful as I have a list of about a hundred downloads and I'm curious when they
went off.

Comment 10

[Prognathous]

Since some of the dupes included the word "column" it would probably be better
to rename the summary of this bug to "Add Date & Time columns for started (or
added) download". This would make it easier for users to find this bug and would
help prevent additional dupes.

Prog.

Comment 11

[David E. Ross]

I have voted for both this and bug 148650 in hope that one of them is
implemented.  For any log, the date and time of the log entry should always be
part of the entry.  

Comment 12

[sturges]

Given that this [simple to resolve] bug/omission has been around for several years with repetitive requests for resolution could someone please address the issue.

Mozilla do a lot of good work but if no one addresses annoying issues it tends to indicate that Open Source does not work so well when it comes to support.

Thanks

Comment 15

[Robert Kaiser]

The new download manager UI introduced by bug 472001 is now aware of that data (both start and end timestamps), as the toolkit download manager records it. We do not expose it in UI yet and have no immediate plans for it, but we possibly would take a patch that adds it in the optional non-default set of available columns.

Comment 16

[Jens Hatlak (:InvisibleSmiley)]

Attachment: proposed patch

Comment 17

[[e-mail]]

Comment on attachment 394723 [details] [diff] [review]
proposed patch

>       <treecol id="TimeElapsed" hidden="true"
>                label="&col.timeelapsed.label;"
>                tooltiptext="&col.timeelapsed.tooltip;"
>                class="sortDirectionIndicator" flex="1"
>                persist="width hidden ordinal sortActive sortDirection"/>
>       <splitter class="tree-splitter"/>
>+      <treecol id="StartTime" hidden="true"
>+               label="&col.starttime.label;"
>+               tooltiptext="&col.starttime.tooltip;"
>+               class="sortDirectionIndicator" flex="1"
>+               persist="width hidden ordinal sortActive sortDirection"/>
>+      <splitter class="tree-splitter"/>
>+      <treecol id="EndTime" hidden="true"
>+               label="&col.endtime.label;"
>+               tooltiptext="&col.endtime.tooltip;"
>+               class="sortDirectionIndicator" flex="1"
>+               persist="width hidden ordinal sortActive sortDirection"/>
>+      <splitter class="tree-splitter"/>
>       <treecol id="Source" hidden="true"
>                label="&col.source.label;"
>                tooltiptext="&col.source.tooltip;"
>                class="sortDirectionIndicator" flex="1"
>                persist="width hidden ordinal sortActive sortDirection"/>
[Strange that this list is in a slightly different order to the other three...]

Comment 18

[[e-mail]]

Comment on attachment 394723 [details] [diff] [review]
proposed patch

[I wonder whether any of our columns should be right-aligned?]

>+      case "StartTime":
>+        if (dl.startTime)
>+          return new Date(dl.startTime).toLocaleString();
>+        return "";
>+      case "EndTime":
>+        if (dl.endTime)
>+          return new Date(dl.endTime).toLocaleString();
>+        return "";
I've just remembered that we don't use toLocaleString on dates. Instead I'd do something similar to what we do for History. sr=me with that fixed.

Comment 19

[Closed Account]

(In reply to comment #18)
> (From update of attachment 394723 [details] [diff] [review])
> [I wonder whether any of our columns should be right-aligned?]

You could have to columns left aligned by default but when a user right clicks on the columns they can select left or right alignment.

Comment 20

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2

(In reply to comment #18)
> (From update of attachment 394723 [details] [diff] [review])
> [I wonder whether any of our columns should be right-aligned?]
> 
> >+      case "StartTime":
> >+        if (dl.startTime)
> >+          return new Date(dl.startTime).toLocaleString();
> >+        return "";
> >+      case "EndTime":
> >+        if (dl.endTime)
> >+          return new Date(dl.endTime).toLocaleString();
> >+        return "";
> I've just remembered that we don't use toLocaleString on dates.

Counter example (not saying it's better): abCardViewOverlay.js

> Instead I'd do something similar to what we do for History.

Probably a good idea.

(In reply to comment #19)
> (In reply to comment #18)
> > (From update of attachment 394723 [details] [diff] [review] [details])
> > [I wonder whether any of our columns should be right-aligned?]
> 
> You could have to columns left aligned by default but when a user right clicks
> on the columns they can select left or right alignment.

I guess Neil was referring to the default, static settings. Adding the ability to switch alignments seems a bit excessive to me. ;-)

Anyway, IMHO that discussion should be taken to a new bug - if anyone really cares about it.

Comment 21

[Frank Wein [:mcsmurf]]

Pushed to comm-central http://hg.mozilla.org/comm-central/rev/2870eb8a8beb