180823 - remove QA and Debug menus and prefs panel from 1.2 branch

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Asa Dotzler [:asa]]

we need to clean up the build for the final release. Bare minimum remove the
Debug and QA menus. If possible also the debug preferences panel. If there's
time it would also be nice to remove the tinderbox sidebar panel and the lxr and
bugzilla search plugins.

Comment 1

[Asa Dotzler [:asa]]

note that removing the search plugins should be pretty easy and would help us
significantly with bugzilla perf (we're getting a lot of "not intended for
bugzilla" searches lately and myk's pointing the finger at mozilla milestone
users somehow having it set as their default search engine).

Comment 2

[eberry]

The titlebar build ID is another thing to consider removing

Comment 3

[Malcolm Rowe]

Note: Bug 163246 was the equivalent bug for the 1.1 milestone release.

Comment 4

[Peter Lairo]

Shouldn't milestone "users" be testing and debugging Mozilla also? WONTFIX?

Comment 5

[Michel Joly de Lotbinière]

I wonder how many users there are such as I, who use the Mozilla milestone
releases as their default WWW/email clients? I know this flies in the face of
mozilla.org's advice that these are experimental releases, but Netscape's
commercial releases just bring too much unwanted nonsense with them.

For this group, who are not actively testing or making fixes to the trunk
builds, the QA & Debug menus, the tinderbox sidebar, and the lxr & bugzilla
plugins are not really relevant. I simply bookmark the entry pages for the
various Mozilla web tools and I add bookmarks to individual bugzilla pages for
any problems directly affecting the milestone.

Comment 6

[Daniel (Leaf) Nunes]

we've removed these from "final" releases in the past (1.0, 1.1) for the reasons
Michel Joly de Lotbinière pointed out.

Comment 7

[Daniel (Leaf) Nunes]

Attachment: remove debug menus/prefs, remove builid from titlebar

I think this is what we want.

Comment 8

[Christopher Blizzard (:blizzard)]

Comment on attachment 106864 [details] [diff] [review]
remove debug menus/prefs, remove builid from titlebar

sr=blizzard

Comment 9

[[e-mail] (away - not reading bugmail)]

Comment on attachment 106864 [details] [diff] [review]
remove debug menus/prefs, remove builid from titlebar

Looks great!

The only nit I'd see in my microscope is about consistency; I'd have either
deleted or commented out those entries :-)

Comment 10

[Daniel (Leaf) Nunes]

i blame blizzard. I'll checkin presently.

Comment 11

[Daniel (Leaf) Nunes]

should be verifiable in any 1.2 build made after 2002/11/20 17:00 PST

Comment 12

[Michael Lefevre]

what about the sidebar/search changes Asa mentioned in comment 1? or have those
been decided against? anything that helps the performance of bugzilla and lxr
has got to be good if you ask me...

Comment 13

[Jon Granrose]

verified 20021121 on win32.  no qa or debug menus and no buildid in titlebar