182171 - "Javascript" should be "JavaScript " and more...

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Henrik Gemal]

In the debug panel it says:
"Show Javascript errors and warnings in Mozilla chrome in the js console"

lets change this to:
"Show JavaScript errors and warnings in chrome"

everybody knows that the warnings are located in the console and JavaScript is
spelled with capital S and it's not only Mozilla chrome. It's also chrome for
installed applications like calendar stuff from mozdev etc...

Patch coming...

Comment 1

[Henrik Gemal]

Attachment: patch to fix wording. No code change...

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 107578 [details] [diff] [review]
patch to fix wording. No code change...

r=glazman

Comment 3

[Henrik Gemal]

rs=brendan since this is wording only

checkin anyone?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 107578 [details] [diff] [review]
patch to fix wording. No code change...

>Index: mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-debug.dtd

>-<!ENTITY debugConsoleJavascript.label    "Show Javascript errors and warnings in Mozilla chrome in the js console">
>+<!ENTITY debugConsoleJavascript.label    "Show JavaScript errors and warnings in chrome">

If you were changing just Javascript -> JavaScript I would say ok, and land
this, but if you are making changes like this, please make sure to get a module
owner or peer to look at this.

I think that the new wording may be somewhat misleading.  It could very easily
be construed that the chrome is where the errors and warnings will be shown
(ala: Show "The Two Towers" in theaters, Show the clip in Windows Media Player,
etc...) Perhaps better wording would be along the lines of "Show chrome
JavaScript errors and warnings"?

Comment 5

[Henrik Gemal]

Attachment: new and better patch

good points. thanx!
text is now "Show chrome JavaScript errors and warnings"

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 107687 [details] [diff] [review]
new and better patch

r=caillon

Comment 7

[Henrik Gemal]

Comment on attachment 107687 [details] [diff] [review]
new and better patch

please review ths small wording cleanup

Comment 8

[Alec Flett]

Comment on attachment 107687 [details] [diff] [review]
new and better patch

sr=alecf but next time please just roll something like this into a bigger patch
- its really a waste of my time and yours to have a whole seperate review for a
single character string change.

Comment 9

[Henrik Gemal]

timeless: can you checkin?

Comment 10

[Henrik Gemal]

need checkin...:)

Comment 11

[timeless]

done

Comment 12

[Steve Chapel]

This was fixed a while ago...

Comment 13

[Grace Bush]

verified code fix