18276 - [CRASH] in gtk code when trying to paste unicode

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Akkana Peck]

When trying to paste unicode, we crash in gtk code trying to get data from the
native clipboard:

#12 0x405ec9b9 in gtk_main_iteration_do ()
#13 0x405223af in nsClipboard::DoRealConvert (this=0x842fcf0, type=0)
    at nsClipboard.cpp:424
#14 0x40522524 in nsClipboard::DoConvert (this=0x842fcf0, format=3)
    at nsClipboard.cpp:465
#15 0x4052293f in nsClipboard::GetNativeClipboardData (this=0x842fcf0,
    aTransferable=0x8533090) at nsClipboard.cpp:538
#16 0x405412e1 in nsBaseClipboard::GetData (this=0x842fcf0,
    aTransferable=0x8533090) at nsBaseClipboard.cpp:102
#17 0x4157e752 in nsHTMLEditor::Paste (this=0x84fee20) at nsHTMLEditor.cpp:3561
#18 0x415af89d in nsHTMLEditorLog::Paste (this=0x84fee20)
    at nsHTMLEditorLog.cpp:357

In order to see this, apply the attached patch in editor/base, then try a simple
plaintext paste into the editor window.

This is blocking I18n pasting on all platforms (because the editor code is XP
and can't be checked in until the Linux crash is fixed).

Since this is crashing inside gtk, the real fix may involve a gtk fix or an
elaborate workaround.  As a temporary fix, I'd like to change line 465 of
nsClipboard.cpp from
    r = DoRealConvert(sSelTypes[TARGET_COMPOUND_TEXT]);
to
    r = DoRealConvert(GDK_SELECTION_TYPE_STRING);
which does fix the problem (but not in the right way).

Comment 1

[Akkana Peck]

Attachment: Patch for the editor to enable unicode pasting

Comment 2

[Stuart Parmenter]

Attachment: patch to fix bad behavior

Comment 3

[Stuart Parmenter]

checked in fix

Comment 4

[Claudius Gayle]

code level fix, amrking VERIFIED

Comment 5

[Akkana Peck]

I don't see how a crash when trying to paste unicode is a code level fix, but,
whatever ..

Comment 6

[Stuart Parmenter]

to see it, the unicode pasting patch would have had to be applyed... its hard to
apply code patches to binaries... :-)