Closed
Bug 183622
Opened 22 years ago
Closed 21 years ago
Can't drop URL objects onto Mozilla
Categories
(SeaMonkey :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: t4qohfl402, Assigned: mkaply)
Details
Attachments
(1 file, 2 obsolete files)
15.96 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; es-AR; rv:1.2.1) Gecko/20021201 Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; es-AR; rv:1.2.1) Gecko/20021201 In Netscape 4.61 and earlier, dropping a URL object (WPUrl WPS class, I think) onto the browser client area (and probably other places) opens that URL. That doesn't work with Mozilla, everywhere I get the "no way" sign, which is a pity since I prefer folders with URL objects rather than bookmark files. Reproducible: Always Steps to Reproduce: 1. Open Mozilla 2. Open a WPS folder with URL objects. 3. Drag the object. 4. Drop it onto anywhere in the Mozilla window. 5. ... 6. Profit! (No, just joking) Actual Results: Nothing Expected Results: Move the current tab to the URL contained into the URL object. If it is dropped onte a hidden tab, it should bring that tab to the front perhaps. The theme is Modern. The Browser ID is seen by Bugzilla as es-AR, but I see the interface in English. I haven't changed the interface language yet. I don't know if it has picked the "es-AR" from the previus version (1.2 beta, I think), which had UABar or prefbar. Maybe it was picked when I have tried to open Phoenix 0.4 besides Mozilla. I use the WPS extension DragText 3.7. It can insert URL objects as text in arbitrary programs, but not in Mozilla windows. I think this is difficult to solve in XUL, but I do like URL objects. An alternative would be dropping onto a program that through DDE sends the URL to Mozilla, I'll have to check if NetscDDE in XWorkPlace can do that.
Assignee | ||
Comment 1•22 years ago
|
||
Nice Southpark reference. Yeah, we know about this one. I've just been putting it off. I'll take it for now.
Assignee: asa → mkaply
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•21 years ago
|
||
OK, this is patch one. It adds drag drop from the desktop (including stuff with spaces which was broke in 1.3) It also adds the ability to hold down the Ctrl key to make copies of web pages and images locally. Last thing to do is filename munging (http://www.yahoo.com -> www_yahoo_com.html)
Comment 3•21 years ago
|
||
Why do we need filename munging? Is this primarily to avoid incorrect handling of extensions by the WPS?
Assignee | ||
Comment 4•21 years ago
|
||
basically to work like 2.02. What should the filename be when you drag http://www.yahoo.com/ to the desktop to get the HTML? Obviously, http://www.yahoo.com/page.html should be page.html.
Assignee | ||
Comment 5•21 years ago
|
||
OK, final patch. Some of this is a little hackish but I did the best I could. This makes drag drop work pretty cool.
Attachment #118347 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #118444 -
Flags: review?(pedemont)
Comment 6•21 years ago
|
||
Comment on attachment 118444 [details] [diff] [review] Final fix You are doing multiple NS_ConvertASCIItoUCS2 calls to put text into dragData. Instead, make dragData an nsCAutoString and just do one big NS_ConvertASCIItoUCS2 at the end. Otherwise, r=pedemont
Attachment #118444 -
Flags: review?(pedemont) → review+
Assignee | ||
Comment 7•21 years ago
|
||
last fix with Javier's stuff so that I can check it in from home.
Attachment #118444 -
Attachment is obsolete: true
Assignee | ||
Comment 8•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•