183994 - Filter dialogs: UI Nits

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[jglick]

Trunk, windows 2002120508 build.

1. Bug 169938 - Message Filters dialog: Clean up new status bar (looks like a
non-working button).

2. Remove the "or the/and the" text in the criteria list. They don't work
correctly consistency, so lets just remove them. See bug 40356 and bug 82015.

3. Weird cropping of dropdown widget. See screenshot below.

4. Widgets should be long enough to display the entire text of their selections
(or majority of them). We currently crop most of the available selections. The
first dropdown list (criteria area) can be shorter since its selections are
shorter. The other dropdowns should be longer. Less spacing between dropdown
widgets can also allow for horizontally longer dropdown lists. Item #2 should
also help with this. This applies to the Actions section as well. 

5. Criteria area is currently only showing One line. It should show 3 lines by
default. The size of criteria area should be large enough for 3 lines only,
there shouldn't be extra space below (3.5 lines visible). 

6. Criteria and Actions area. Reduce the amount of vertical spacing between
items. See spec for example.

7. Missing mnemonics: "Match _a_ny of the ..." "Match all _o_f the..."

8. Remove "More" and "Fewer" buttons and add + and - buttons per line. This
makes it easier to insert or remove a line in a specific order. See spec.
http://www.mozilla.org/mailnews/specs/filters/#Filter%20Rules%20D

Comment 1

[jglick]

Attachment: Examples

See:
http://www.mozilla.org/mailnews/specs/filters/#Filter%20Rules%20D

Comment 2

[laurel]

Regarding point #2 about the and/or text:  This was corrected with bug 171236. 
I've commented in both bug 40356 and bug 82015 accordingly. Unless there's a
decision that we'll take it out even though it's working?

Comment 3

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 4

[Cavin Song]

Reassigning.

Comment 5

[Cavin Song]

reassigning.

Comment 6

[shliang]

Attachment: patch

for items 1-6, 8

i am not sure if you can put mnemonics on radios at the moment, will look into
that.

Comment 7

[(not reading, please use [e-mail] instead)]

talked it over with mail-triage and qa.

"8. Remove "More" and "Fewer" buttons and add + and - buttons per line. This
makes it easier to insert or remove a line in a specific order. See spec.
http://www.mozilla.org/mailnews/specs/filters/#Filter%20Rules%20D"

this part of this fix that adds the "more/less" buttons is a lot of risk for the
reward.

I've spun it off to bug #195224 (1.5 alpha).  can break apart your patch and
attach the more/less part to that bug, and leave the rest here?

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 115157 [details] [diff] [review]
patch

clearing review requests until there is a patch without the more/less fix.

Comment 9

[shliang]

Attachment: patch without more/less buttons

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 115800 [details] [diff] [review]
patch without more/less buttons

just some minor nits.

address them, and then I'll sr.

1)

     window.alert(str);
+    gFilter = null;
     return false;

over aim, shuehan explained:

at the very beg. it seems to not save your filter if you don't select an action
+ get the error msg because it sets gNewFilter var to false when it's supposed
to be true?
so if you make a filter then don't select an action, get the alert, go back and
select an action then close, the filter isn't there.

can log a new bug (or query for it first) so when you check in this fix, QA
will know about it?

then do:

+    // see bug #xxxxxx
+    gFilter = null;

2)

+  style="width:560px;min-height:1px"

this style should not be inline, right?


3)

-  <hbox id="statusContainerBox" align="center">
-    <spacer flex="1"/>
-    <label id="statusText" crop="right" flex="1"/> 
+  <statusbar class="chromeclass-status" id="status-bar">    
+    <statusbarpanel class="statusbarpanel-progress">
     <progressmeter class="progressmeter-statusbar" id="statusbar-icon"
mode="normal" value="0"/>
-  </hbox>
+    </statusbarpanel>
+    <statusbarpanel id="statusText" crop="right" flex="1"/>
+  </statusbar> 
+
 </window>

can you attach a screen shot of the filter list dialog?  

I think cavin owns a bug about fixing this dialog, you should take it from him
if you haven't already.

4)

can you include a comment linking back to the bug about hiding these cells?

+      // see bug #xxxxxx for while these cells are hidden
+      listcells[i].hidden = true;
     }
     searchTermObj.booleanNodes = stringNodes;


+	   // see bug #xxxxxx for while these columns are hidden
+	   <listcol flex="&searchTermListSpace1FlexValue;" hidden="true"/>

Comment 11

[(not reading, please use [e-mail] instead)]

actually, please do:

+    // reset gFilter because...
+    // see bug #xxxxxx
+    gFilter = null;

Comment 12

[shliang]

Attachment: revised patch

Comment 13

[shliang]

Attachment: filter list dialog

1. Bug 169938 - Message Filters dialog: Clean up new status bar (looks like a
non-working button).

i already own this bug.

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 115805 [details] [diff] [review]
revised patch

r/sr=sspitzer

nice work, shuehan.

Comment 15

[shliang]

marking fixed.

Comment 16

[jglick]

Attachment: Example

Shuehan, nice work. Thanks. A couple things I noticed using the 2003030308
build:

1. Weird space above scroll bars now appears.
2. When a scroll bar appears in criteria area, the text boxes are overlapped.
3. Still seeing weird white line in dropdown widgets. (could be a global
issue?)
4. 3 criteria and 3 actions should be viewable without having to scroll.
(currently only 2 are visible).
5. Is it possible to move the action items closer together (vertically) so they
match the spacing between the criteria items?

Comment 17

[esther]

Using trunk builds on winxp macosx and linux and a new default profile the items
mentioned in original scenario items 2, 3, 4 and 5 are fixed, 7&8 not going in,
6 mentinted in comment 16.
In comment 16, I still see:
#3 if I haven't selected a folder for the default account. The dropdowns resize
once I select a folder and then they are OK.
#4 is ok for a new profile the first time I bring up the New Filter dialog.
Windows shows 6 criteria, 6 actions. Mac OSX shows 7 criteria 7.5 actions, Linux
shows 6 criteria, 6 actions.  
#5 on Mac OSX spacing is really close- win and linux not,
Reopening for now.

Comment 18

[shliang]

regarding comments 16/17:

1. Weird space above scroll bars now appears.
This is my fault, will attach patch.

2. When a scroll bar appears in criteria area, the text boxes are overlapped.
This regressed at some point before my checkin and probably should be spun off 
to a new bug?

3. Still seeing weird white line in dropdown widgets.
This is a problem in the layout code and a global issue.

4. 3 criteria and 3 actions should be viewable without having to scroll.
(currently only 2 are visible).
Changes I made will only be visible with a new profile, as the width and 
height of the window is persisted from the last time you opened it. I could 
get around this (reset the size for everyone) if you think it is necessary.

5. Is it possible to move the action items closer together (vertically) so they
match the spacing between the criteria items?
Not sure what to do with this, since there is not extra space on Mac?

Comment 19

[shliang]

Attachment: patch for comment 16 item 1

Comment 20

[jglick]

>2. This regressed at some point before my checkin and probably should be spun
>off to a new bug?

Esther, can you file a bug?

>3. This is a problem in the layout code and a global issue.

Esther, do you know if there is an existing bug, and if not can you file one?

>4. Changes I made will only be visible with a new profile, ...

Good enough for me. :-)

>5. Not sure what to do with this, since there is not extra space on Mac?

You can ignore this one if its a problem. It was more the combo of #4 and 5 that
made the criteria/actions areas seem small.

Comment 21

[(not reading, please use [e-mail] instead)]

Comment on attachment 116264 [details] [diff] [review]
patch for comment 16 item 1

r/sr=sspitzer

Comment 22

[shliang]

fixed item 1 in comment #16, think that should be it right?

Comment 23

[Sander]

> Changes I made will only be visible with a new profile, as the width 
> and height of the window is persisted from the last time you opened 
> it. I could get around this (reset the size for everyone) if you think 
> it is necessary.

There were a lot of bugs reported by people using 1.2 profiles moving to 1.3 
builds and then thinking the "more" criteria button stopped working, because 
the top pane was too small. See bug 194250 and similar dupes for the confusion 
(the default size was too small for the scrollbar to appear). If this still is 
the case after this fix, I do think resetting the size for everyone would be a 
really good idea. (I wish I could simply grab a build and do some testing for 
myself, but I've been without a computer for the past three weeks.) :/

Comment 24

[Sander]

*** Bug 199057 has been marked as a duplicate of this bug. ***

Comment 25

[Ninoschka Baca]

Trunk build 2003-04-10: WinXP, Mac 10.1.5, Linux RH 8
The following items are related to comment 18/20 plus additional issues.

2. This problem no longer appears.

3. ** The white line is still present but I only see it in Windows build.

4. I can see between 6 and 7 lines at one time if desired so this is more than 2
as described in comment 16.

5. ** The Modern theme displays the extra space but the Classic theme does not
so I think this problem is related to the theme. 

6. ** Add lines so that a scrollbar appears, place the cursor in one of the text
boxes (and notice that there is a light highlight), scroll up/down and notice
that the line with the cursor now has a dark highlight. I would expect a light
highlight to remain. This occurs on all platforms and in classic/modern themes.
The only time I don't see this problem is on the Mac using the classic theme.

7. ** Linux/classic only problem where the text boxes for additional criteria
display garbage in the borders. 

Should I reopen this bug or create new bugs?

Comment 26

[Ninoschka Baca]

I logged separate bugs for issues 3, 6 and 7:

3. Bug# 202034 to track the white line problem.
6. Bug# 202036 to track the dark highlight appearing after scrolling
7. Bug# 202038 to track the linux/classic, garbage in text box border

Item 5 is ok with jglick as stated in comment 20.

For the above reasons I'll mark this bug as Verified Fixed.

Comment 27

[Sander]

*** Bug 205804 has been marked as a duplicate of this bug. ***

Comment 28

[:aceman]

(In reply to (not reading, please use [e-mail] instead) from comment #10)
> can you include a comment linking back to the bug about hiding these cells?
> 
> +      // see bug #xxxxxx for while these cells are hidden
> +      listcells[i].hidden = true;
>      }
>      searchTermObj.booleanNodes = stringNodes;
> 
> 
> +	   // see bug #xxxxxx for while these columns are hidden
> +	   <listcol flex="&searchTermListSpace1FlexValue;" hidden="true"/>

Does anybody know today why those cells/columns are there and hidden?

And it looks like patch in comment 21 never landed or it was reverted, because listbox still has the 2px padding.

The filter editor was reworked a bit since the time of this patch so I'll look at it again, if it can be simplified.