184588 - [gtk native themes] border is incorrectly applied to <toolbox>

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Brian Ryner (not reading)]

My checkin for bug 174927 accidentely caused us to start applying a border to
toolbox elements.  This causes the menu bar and all the toolbars to be inset
from the edge of the window.

Unfortunately, gtk doesn't have a concept of a 'toolbox' that's different from a
toolbar (in mozilla-speak, the toolbox is the thing that encloses the 3 toolbars
at the top of the browser window).  I think the gtkdrawing.c implementation of
the toolBAR border is correct, aside from using a handlebox instead of a
gtktoolbar.  I'd propose that we fix nsNativeThemeGTK.cpp to know that toolBOX
does not correspond to any gtk widget for purposes of a border, and hardcode it
to a 0 pixel border.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 108847 [details] [diff] [review]
patch

r=blizzard

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 108847 [details] [diff] [review]
patch

sr=[e-mail]

Comment 4

[Brian Ryner (not reading)]

checked in.

Comment 5

[Grace Bush]

verified code fix