184703 - Better way of setting |isPre| parameters.

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

bz suggested in bug 1777 comment 226 that we should have a method on the style
struct that tests whether whitespace is PRE or PRE_WRAP.  This would simplify a
bit of code.

When doing this, I should also correct the XXX comment cited in that comment by
walking up to the closest block (unless we want to change our implementation of
the 'white-space' property to apply to inlines as well).

Comment 1

[Boris Zbarsky [:bzbarsky]]

There's also code in Inspector that could use the new function on the style
struct...

Comment 2

[Hixie (not reading bugmail)]

This should take into account the CSS3 text properties, which will split
white-space into a gazillion different axes.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Of course, we won't need the parameter once 'white-space' applies to all
elements rather than just blocks, which I think is a CSS 2.1 change.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is all fixed now.  See particularly bug 191699, bug 261081, maybe bug 393096, although there were other pieces (including a big patch from roc that I can't find).