185465 - mismatched alloc/delete in qt/nsWidget.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Ports: Qt, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

will attach a patch in a second

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

timeless, could you review?

fwiw, the valgrind message was:

==2554== Mismatched free() / delete / delete []
==2554==    at 0x4003B1A3: __builtin_vec_delete (vg_clientfuncs.c:214)
==2554==    by 0x45D031D7: nsWidget::SetTitle(nsString const &)
(../../../../widget/src/qt/nsWidget.cpp:598)
==2554==    by 0x80614D3: nsBrowserWindow::SetTitle(unsigned short const *)
(../../../../webshell/tests/viewer/nsBrowserWindow.cpp:431)
==2554==    by 0x808548B: nsWebBrowserChrome::SetTitle(unsigned short const *)
(../../../../webshell/tests/viewer/nsWebBrowserChrome.cpp:367)
==2554==    Address 0x4626A1F0 is 0 bytes inside a block of size 19 alloc'd
==2554==    at 0x4003ADE2: malloc (vg_clientfuncs.c:100)
==2554==    by 0x4052846D: PR_Malloc
(../../../../../nsprpub/pr/src/malloc/prmem.c:433)
==2554==    by 0x404714AF: nsMemoryImpl::Alloc(unsigned int)
(../../../xpcom/base/nsMemoryImpl.cpp:320)
==2554==    by 0x404B3E73: nsMemory::Alloc(unsigned int)
(../../../xpcom/glue/nsMemory.cpp:87)

Comment 2

[timeless]

*** Bug 184610 has been marked as a duplicate of this bug. ***

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsWidget.cpp;
/cvsroot/mozilla/widget/src/qt/nsWidget.cpp,v  <--  nsWidget.cpp
new revision: 1.21; previous revision: 1.20
done