Closed
Bug 185985
Opened 22 years ago
Closed 19 years ago
keyword without arguments is sending string "%s"
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stf, Assigned: jaas)
Details
Attachments
(1 file)
6.11 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
If you define a bookmark (without the "quotes") where %s is used e.g.: Name="SearchIt" URL="http://google.com/search?query=%s&num=10" Keyword="?" If you type "?" alone nothing happens. If you type "? " (?+space) the link is opened but the string "%s" has been used. Build 1217.
Comment 1•22 years ago
|
||
What do you expect to happen?
Reporter | ||
Comment 2•22 years ago
|
||
In both cases open the url with the string "" (empty) for some url it will be a quick way to access them, like for google.
Comment 3•22 years ago
|
||
IMHO, "? " should expand to "http://www.google.com/search?q=" in this example. Note the end of the expanded URL.
I like the idea in bug 175419, bring up an input box for %s/keyword bookmarks. That way I can get rid of my javascript google/freshmeat search bookmarks (which have broken in the past), add in keyword bookmarks that would do the same thing and allow me to do keyword stuffs in the location bar. Then I don't have to try and hide these keyword bookmarks, especially since clicking on them won't always produce something of value.
Comment 5•22 years ago
|
||
Ideally, I'd like to be able to load one url for keyword followed by a argument and another for just the keyword. Example: Bookmark Name: "Google" URL: "http //www.google.com/search?q=%s" keyword: "?" When typing in "? query", Chimera will load "http //www.google.com/search?q=query", but typing in "?" will load "http://www.google.com/". I guess you could parse it to retrieve only the domain of the URL or the directory that the script is contained in. The only problem with this is having a search script in a different directory than the index, though I don't know how often that would arise.
Comment 6•20 years ago
|
||
This bug appears in Firefox (Mac) as well. If you type 'google' into the address bar, it loads a search for %s in google. To my mind, what should happen is that, since you've only typed in one word, it should do a default "I'm feeling lucky" search for that word, and therefore load Google's front page.
Camino doesn't use an "I'm feeling lucky" search when you just type one word, it just appends "http://www." and ".com" to it (personally, I wish Firefox would do the same as I end up at the wrong url half the time, but I digress). What you're suggesting is not really an optimal solution--it would involve ignoring certain bookmark keywords (those that are expecting a search string but don't receive one) which is potentially confusing to the user. I think the most logical (and probably simple) solution is the one suggested in comment #3.
Comment 8•19 years ago
|
||
I would have expected no parameters on a keyworded bookmark to use an empty string for %s as opposed to sending the literal '%s' as a parameter.
Attachment #184108 -
Flags: superreview?(pinkerton)
Comment 10•19 years ago
|
||
Comment on attachment 184108 [details] [diff] [review] make keywords faster and fix this bug v1.0 sr=pink. looks ok to me.
Attachment #184108 -
Flags: superreview?(pinkerton) → superreview+
Assignee | ||
Comment 11•19 years ago
|
||
landed on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•