186689 - Should be able to set all/clear all email options in preferences

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Stephen Rasku]

I have two bugzilla accounts:  one for work and one for home.  When I am not
working, I want to completely disable e-mail for my work account.  When I am
working, I want to re-enable it, again.  Currently, I have to click (or unclick)
each option.  

There should be a two extra buttons under "Field/recipient specific options:". 
One should be labeled "Set all" and the other should be labeled "Clear all"

Comment 1

[Dave Miller [:justdave]]

Attachment: patch v1

"Enable all mail" and "Disable all mail" javascript buttons which set/clear the
appropriate checkboxes.

Comment 2

[Dave Miller [:justdave]]

-> me

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 113358 [details] [diff] [review]
patch v1

>+<script type="text/javascript">
>+<!--
>+
>+function SetCheckboxes(setting) {
>+  for (var count = 0; count < document.userprefsform.elements.length; count++) {
>+    var theinput = document.userprefsform.elements[count];
>+    if (theinput.type == "checkbox") {
>+      if (theinput.name == "ExcludeSelf") {
>+        theinput.checked = false;

Are you sure you mean "false" rather than "!setting"?

Perhaps the need for this exception tells us that this checkbox should have an
inverted sense...

>@@ -108,7 +127,9 @@
>     </td>
>   </tr>
> </table>
>-
>+<noscript>The following two buttons require Javascript to be active<br></noscript>
>+<input type="button" value="Enable All Mail" onclick="SetCheckboxes(true); return false;">
>+<input type="button" value="Disable All Mail" onclick="SetCheckboxes(false); return false;">

I think it's preferable to document.write() the two buttons, rather than have
the slightly clunky message. This is the usual solution for things that only
work with JS.

Gerv

Comment 4

[Dave Miller [:justdave]]

>>+      if (theinput.name == "ExcludeSelf") {
>>+        theinput.checked = false;
>
>Are you sure you mean "false" rather than "!setting"?

Yep...  if the rest of the mail settings are disabled, that's ignored.  But if
you want "ALL" mail, then that needs to NOT be checked.  But having that checked
when the rest of the settings aren't makes it read like you're still going to
get mail, even though it's really going to be ignored.

We had a huge argument over that last time the prefs got redone, and the
concensus at the time was that we didn't want any of the checkboxes to have a
negative description...

>I think it's preferable to document.write() the two buttons, rather than have
>the slightly clunky message.

I was debating on that. :)  Should we put a <noscript> messasge indicating that
they can check/uncheck all the settings with a single button if they enable
Javascript? :)

Comment 5

[Dave Miller [:justdave]]

Attachment: Patch v2

addresses Gerv's nits, with the exception of the "ExcludeSelf" checkbox...

Comment 6

[Dave Miller [:justdave]]

oops, forgot you weren't CC'd, Gerv.  See comment #4

Comment 7

[Gervase Markham [:gerv]]

Now you have two scripts, it makes sense to amalgamate them to keep the code
together. I'm not all that keen on the <noscript> (what they don't know won't
hurt 'em) but if you want to keep it, fine.

With the first change, r=gerv.

Gerv

Comment 8

[Dave Miller [:justdave]]

Attachment: Patch v3

This what you had in mind, re: merging the scripts?

Comment 9

[Gervase Markham [:gerv]]

Exactly. r=gerv. Although you should probably test on e.g. NS 4.x, if these
buttons are outside the <form>, as I'm not sure it supports form controls
outside one. (I can't see from the context.)

Gerv

Comment 10

[Dave Miller [:justdave]]

I thought of that. :)  They're inside the form.  The form itself is actually
defined in a different template (hence the patch to the second file to name it).
 The email.html.tmpl template is entirely inside the form.

Comment 11

[Dave Miller [:justdave]]

Checking in template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.tmpl,v
 <--  prefs.html.tmpl
new revision: 1.9; previous revision: 1.8
done

Comment 12

[Jacob Steenhagen]

*** Bug 201083 has been marked as a duplicate of this bug. ***

Comment 13

[Shane H. W. Travis]

*** Bug 150846 has been marked as a duplicate of this bug. ***