Closed Bug 186819 Opened 22 years ago Closed 19 years ago

Query charset searching on dmoz.org does not match with which dmoz.org expects

Categories

(SeaMonkey :: Search, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: opmolf, Assigned: philor)

Details

Attachments

(3 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-HN; rv:1.3b) Gecko/20021226
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-HN; rv:1.3b) Gecko/20021226

details below

Reproducible: Always

Steps to Reproduce:
1. Set dmoz.org as the search engine: Edit - Preferences... - Navigator -
Internet Search - Search using: dmoz.org
2. Search a string with characters outside the ASCII, for example "mozillá"

Actual Results:  
The query generated by Mozilla is:
http://search.dmoz.org/cgi-bin/search?search=mozill%E1

dmoz.org search for "mozill?"

Expected Results:  
(for example) Generate the query:
http://search.dmoz.org/cgi-bin/search?search=mozill%C3%A1
(which is generated when writing "mozillá" directly on dmoz.org)

It is interesting to see that searching for "mózillá" works properly (two errors
are no error, binary logic ;)
http://search.dmoz.org/cgi-bin/search?search=m%F3zill%E1

But, in general, dmoz.org uses UTF-8 (I think):
http://search.dmoz.org/cgi-bin/search?search=m%C3%B3zill%C3%A1

So, I tried to read those search plugins in "searchplugins" folder of Mozilla
and decided to add a line on "dmoz.src" SEARCH tag: "queryCharset="utf-8""
(changes on dmoz.src added as attachment)

I really don't know the specification of these SRC files but it turns out that
now it works as dmoz.org expects.

Finally, finding similar bugs I have found the 62409 "Local Charsets are not
supported in SearchPlugins", but I think they are not the same although similar.
Attached file Changes on /searchplugins/dmoz.src (obsolete) —
See bug "Missing  queryCharset in google.src",
http://bugzilla.mozilla.org/show_bug.cgi?id=180674.
see also bug 62409
Assignee: samir_bugzilla → asa
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch plugin patchSplinter Review
queryCharset for sending, charset for interpreting, tabs are evil
Attachment #110151 - Attachment is obsolete: true
Attachment #197434 - Flags: superreview?(alecf)
Attachment #197434 - Flags: review?(timeless)
Attached patch -w of aboveSplinter Review
Attached patch website patchSplinter Review
And since it updates from http://www.mozilla.org/projects/search/dmoz.src that
needs to be patched at the same time.
Assignee: asa → bugzilla
Status: NEW → ASSIGNED
Attachment #197434 - Flags: superreview?(dmose)
Attachment #197434 - Flags: superreview?(alecf)
Attachment #197434 - Flags: review?(timeless)
Attachment #197434 - Flags: review+
Comment on attachment 197434 [details] [diff] [review]
plugin patch

sr=dmose
Attachment #197434 - Flags: superreview?(dmose) → superreview+
Whiteboard: [checkin needed]
Fixed, trunk and web.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: