Closed Bug 187500 Opened 22 years ago Closed 22 years ago

selectedIndex broken for <tabs> element

Categories

(Core :: XUL, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: rginda, Assigned: jag+mozilla)

Details

Attachments

(1 file)

The selectedIndex property of the <tabs> element is busted, as of version 1.4 of
tabbox.xml.

It checks tabs.selected, instead of tabs[i].selected.  This breaks Venkman, and
probably a few other things.
Attached patch patchSplinter Review
Attachment #110535 - Flags: superreview?(jaggernaut)
Attachment #110535 - Flags: review?(blaker)
Comment on attachment 110535 [details] [diff] [review]
patch

Oops. sr=jag
Attachment #110535 - Flags: superreview?(jaggernaut) → superreview+
Comment on attachment 110535 [details] [diff] [review]
patch

doh
Attachment #110535 - Flags: review?(blaker) → review+
You may not check into partition Browser
the file mozilla/toolkit/content/widgets/tabbox.xml on branch HEAD
If you think you should be allowed to, send mail to
one of the below people:
  dean_tessman@hotmail.com
  hewitt@netscape.com
  chanial@noos.fr
  blakeross@telocity.com
  hyatt@apple.com

Well then.  Blake, you want to check this in?
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: