Closed
Bug 187575
Opened 22 years ago
Closed 22 years ago
Context menus should not eat clicks outside themselves
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: deanis74, Assigned: aaronlev)
Details
Attachments
(1 file)
793 bytes,
patch
|
deanis74
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
From bug 66834, context menus should also not eat clicks outside themselves. This is Windows-specific, based on bug 66834 comment 77.
Comment 1•22 years ago
|
||
I strongly agree, most un-windows-like :) And inconsistent with Netscape 4.x. Is this bug just for right-click menus or for all menus?
Ian: bug 66834 fixed menus off the menu bar. This bug is just for context menus.
Comment 3•22 years ago
|
||
Hey you're right, its fixed for the menu bar. That's great news :)
Assignee | ||
Comment 4•22 years ago
|
||
Should context menus never eat clicks, on any platform? I don't think they should. Please correct me if I'm wrong.
Assignee | ||
Comment 5•22 years ago
|
||
Sorry, I wasn't reading correctly. Windows only.
Assignee | ||
Comment 6•22 years ago
|
||
Jesse, does this patch help with the Phoenix forms autocomplete?
Assignee | ||
Updated•22 years ago
|
Attachment #110806 -
Flags: review?(dean_tessman)
Comment on attachment 110806 [details] [diff] [review] Treat xul:popupset like xul:menu, for purposes of determining click consumption I like simple. r=me
Attachment #110806 -
Flags: review?(dean_tessman) → review+
Assignee | ||
Comment 8•22 years ago
|
||
Comment on attachment 110806 [details] [diff] [review] Treat xul:popupset like xul:menu, for purposes of determining click consumption Seeking sr= for tiny patch
Attachment #110806 -
Flags: superreview?(alecf)
Comment 9•22 years ago
|
||
Comment on attachment 110806 [details] [diff] [review] Treat xul:popupset like xul:menu, for purposes of determining click consumption sr=alecf hope this got lots of testing! :)
Attachment #110806 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 10•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 11•22 years ago
|
||
Yes, this fixed Phoenix form autocomplete (tested Phoenix 01/07 nightly). I think it also fixed Phoenix address bar autocomplete and Mozilla address bar autocomplete (bug 66834).
Comment 12•22 years ago
|
||
Right-click menus no longer seem to eat clicks, but the menus from personal toolbar folders (including bookmarks) still do. Build ID 2003011405. Win98.
Comment 13•22 years ago
|
||
Context menus in MailNews still eat clicks. Should I raise that as a separate bug?
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•