188213 - Keyboard move/select by word (ctrl+arrow) stops too often in unicode text with punctuation

Status: RESOLVED WORKSFORME

(Core :: DOM: Selection, defect)

Description

[Aaron Leventhal]

[1]unicodetext[2]-[3]unicodetext [4]moretext
(Assume the bracketed numbers are markers, not actually in text).

When hitting Accel+[shift]+arrow to move or select by word it incorrectly stops
both before and after punctuation -- [2] and [3].

user_pref("layout.word_select.stop_at_punctuation", true);
Should only stop at [1], [3] and [4]

user_pref("layout.word_select.stop_at_punctuation", false);
Should only stop at [1] and [4]

Spun off from bug 98546.

Comment 1

[Aaron Leventhal]

Attachment: Some unicode text with punctuation in the middle

Comment 2

[Aaron Leventhal]

Does anyone even fix i18n bugs anymore?

Comment 3

[[e-mail]]

Is bug 236172 a dup of this?

Comment 4

[Simon Montagu :smontagu]

*** Bug 336449 has been marked as a duplicate of this bug. ***

Comment 5

[Uri Bernstein]

Adding some words to the summary to allow for easier finding.

Comment 6

[Uri Bernstein]

Note to self (or anyone else who wants to fix this):

The issue here is that both layout.word_select.stop_at_punctuation and aIsKeyboardSelect are ignored in the "Unicode" case (when the string contains two-byte characters), that is in nsTextTransformer::ScanNormalUnicodeText_F/B.
The behavior is as if layout.word_select.stop_at_punctuation is true, and aIsKeyboardSelect is false.

Comment 7

[Uri Bernstein]

WFM with Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022804 Minefield/3.0b4pre ID:2008022804.

Probably fixed by the new textframe (bug 367177).