Closed
Bug 188956
Opened 22 years ago
Closed 21 years ago
Clean up Cache pref panel.
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: skasinathan, Assigned: skasinathan)
References
Details
Attachments
(2 files, 2 obsolete files)
57.94 KB,
image/jpeg
|
Details | |
6.48 KB,
patch
|
janv
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
There are few things that needs to be cleaned/removed from Cache pref panel. Darin: What are the items that needs to be cleaned? Couple of them you mentioned to me are, (correct me if i'm wrong) 1. Removing Memory Cache from the panel. 2. Replace KB with MB. Thanks!
Comment 1•22 years ago
|
||
1- probably, although if folks object then we should at least have only one "clear cache" button. 2- yes. 3- also, try to widen the cache directory entry box if possible.
This attachment is just the initial work...I'll talk to Patrice about her opinion. Adding pre-fetching pref to Cache panel is still an issue :(
how about change the text to "Cache", instead of "Disk Cache" Cache: 50000kb [ Clear Cache ] what do people think? I also agree that prefetching option makes this panel to crowded. I like the screen shot in bug 166648 better, under the http networking panel.
Comment 4•22 years ago
|
||
yeah, let's eliminate the word "Disk" throughout. as for the prefetching pref, the HTTP Networking panel makes sense assuming prefetching only applies to HTTP content which is currently the case, but... dougt mentioned wanting to possibly prefetch other things like FTP directory listings. prefetching doesn't inheritantly have anything to do with HTTP.
Comment 5•22 years ago
|
||
If memory cache is removed from panel, how can it be limited, so Mozilla doesn´t take all available ram for cache? iirc I saw some people complaining about Opera7 taking all of ram, but I´m not sure about this.
Comment 6•22 years ago
|
||
Hermann: mozilla has a memory cache limit of 4MB. it is not meant to be modified. except.. in the future, mozilla will likely have a memory cache size that is more proportional to the amount of available RAM. though don't expect it to ever be very large. advanced users can still adjust the memory cache size manually by editing prefs.js. suresh: isn't this bug fixed now that bug 166648 has been fixed?
darin: There is one more task to be fixed in this bug - change KB to MB.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4alpha
Attachment #113537 -
Flags: superreview?(darin)
Attachment #113537 -
Flags: review?(gordon)
I don't think we can change the semantics of this pref from kilobytes to megabytes without migrating existing pref settings. If a user has changed this setting, and new browsers interpret it as Mb rather than kb, that might be bad.
Assignee | ||
Comment 10•22 years ago
|
||
gordon/darin: any thoughts on how to migrate the existing user setting from KB to MB? thanks!
Comment 11•22 years ago
|
||
Comment on attachment 113537 [details] [diff] [review] patch to convert KB to MB. hmm... the actual meaning of the pref strings in all.js should not change. only the UI should change. if you change the meaning of a pref string then you will have to add code to migrate existing users profiles.
Attachment #113537 -
Flags: superreview?(darin)
Attachment #113537 -
Flags: superreview-
Attachment #113537 -
Flags: review?(gordon)
Comment 12•22 years ago
|
||
suresh: sorry, missed the last two comments. just change the UI, not the preferences backend. i know this complicates the prefs XUL code a bit, but it is far superior to any profile migration headache.
Assignee | ||
Comment 13•22 years ago
|
||
1. This patch just converts KB to MB on loading the cache panel and converts back to KB while saving the pref. 2. I changed 50000 to 51200 KB, which is exactly 50 MB ;-) Users who have modified the Cache value before, should still work fine. 3. Thanks to Neil for his help here!
Attachment #113537 -
Attachment is obsolete: true
Comment 14•22 years ago
|
||
Comment on attachment 113704 [details] [diff] [review] updated patch I think you missed a bit from this patch :-( Also, do you have any idea why unix.js has its own copy of the pref?
Assignee | ||
Comment 15•21 years ago
|
||
Attachment #113704 -
Attachment is obsolete: true
Attachment #118307 -
Flags: superreview?(jaggernaut)
Attachment #118307 -
Flags: review?(varga)
Comment 16•21 years ago
|
||
*** Bug 198912 has been marked as a duplicate of this bug. ***
Comment 17•21 years ago
|
||
Comment on attachment 118307 [details] [diff] [review] updated patch r=varga
Attachment #118307 -
Flags: review?(varga) → review+
Attachment #118307 -
Flags: superreview?(jaggernaut) → superreview?(alecf)
Comment 18•21 years ago
|
||
Comment on attachment 118307 [details] [diff] [review] updated patch + function GetFields(pageData) { + pageData.browserCacheDiskCache.value <<= 10; + return null; You need a comment on the signifigance of the <<=10 (i.e. because the cache is in kilobytes, and the UI is in megabytes) other than that, looks good. sr=alecf
Attachment #118307 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 19•21 years ago
|
||
moving to mozilla 1.4beta.
Target Milestone: mozilla1.4alpha → mozilla1.4beta
Comment 20•21 years ago
|
||
What about CACHE FOLDER? Does anybody in here use that? I don't see the point and would like for that to be removed from Mozilla too.
Comment 21•21 years ago
|
||
a few user need this to set this to another location if the whole profile is stored on the network.
Comment 22•21 years ago
|
||
never mind then
Assignee | ||
Comment 23•21 years ago
|
||
fixed in trunk.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 24•19 years ago
|
||
*** Bug 299510 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•