190124 - Save Page As... complete missing image

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Tracy Walker [:tracy]]

seen on linux commercial trunk build 2003-01-22-05-trunk

-following instructions for smoketest B.27:
-goto test URL
-Select File | Save Page As
-in file picker make sure Web Page, Complete is selected in Files of type:
-Save
-then File | Open File and the the mozorg.html file

tested results: the page is missing the mozilla.org header image

expected results: the page is rendered complete with all images

Comment 1

[Tracy Walker [:tracy]]

The image missing from the File Open display is actually present in the saved
mozorg_files folder.  But it is not being picked up by File Open.  I tried file
open of this Saved page with an older version of mozilla and the header is still
missing.

Comment 2

[Tracy Walker [:tracy]]

On windows build 2002-01-22-10-trunk Save Page As doesn't save anything. 

follow steps to test as above:

tested results:  No page is saved at all

expected results:  Page is saved to selected directory with supporting images file

this is worse than what I'm seeing on linux.  If it is believed to be a
different bug please open another.

Comment 3

[Peter Trudelle]

reassigning to sgehani for triage

Comment 4

[Jan Varga [:janv]]

This is probably the same problem as in bug 190121.
I tried to view saved page in N7.0 and it didn't work either.
When I looked at source code I found out that there are two attributes
on the image element, width="0" and height="0".
This is obviously wrong.

Comment 5

[ArronM (:paper)]

Attachment: Patch

Send Pixel Units to GetPixelValue, not GetIntValue (which asserts and returns)

Comment 6

[ArronM (:paper)]

I wasn't getting the problem in Comment #2.

Comment 7

[Tracy Walker [:tracy]]

is this the same issue with bug 190121? dupe?

Comment 8

[John Keiser (jkeiser)]

Comment on attachment 112327 [details] [diff] [review]
Patch

Wow, I suck.  Good catch.  I don't see any more of these in nsHTMLValue.cpp.

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 112327 [details] [diff] [review]
Patch

sr=blizzard

Comment 10

[Jan Varga [:janv]]

I can confirm that backing out of jkeiser's HTMLValue checkin fixed this bug.
and bug 190121 too.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 112327 [details] [diff] [review]
Patch

a=roc+moz

Comment 12

[ArronM (:paper)]

checked-in

Comment 13

[Tracy Walker [:tracy]]

verified with linux respin 2003-10-22-14-trunk