190382 - selectionEnd off by one when user selects text via CMD/CTRL-A

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Chris Casciano]

Text copied from my comment in Bug 88049. Please switch Platform/OS:ALL if
you're seeing this elsewhere.

Just trying to hack together some quick editor buttons (similar to that of
blogger and movable type) at hit some strange behavior (that is available in the
current testcase). It seems that when a user highlights all the text with the
mouse selectionEnd == length, however when selecting all text with CMD/CTRL-A
selectionEnd == length + 1. While inserting text at this higher value seems to
work properly, it screws with resetting focus in the following example:

http://placenamehere.com/Mozilla/js_textareas.html

You'll notice that if you select all the text in the textarea via CMD-A and then
hit one of the editor buttons it throws off my calculation for the new
selectionEnd and grabs the first character in the newly inserted tag.

My Build:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.3b) Gecko/20030122


While I can easily test that the selection isn't longer the then length in my
script to get it to work, should I have to? Is there a reason for this behavior?

Comment 1

[kinmoz]

Attachment: Patch Rev 1

Here's the patch that fixes the problem. We shouldn't be counting the last BR
under the root node as a character. I also fixed 3 warnings related to signed
comparisons.

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 112463 [details] [diff] [review]
Patch Rev 1

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 3

[kinmoz]

Fix checked into TRUNK:

  mozilla/layout/html/forms/src/nsTextControlFrame.cpp  rev 3.114

Fix should appear in 8am trunk daily builds and the Mozilla 1.3 beta.

Comment 4

[Chris Casciano]

Confirming Fix on OS X/MachO Nightly:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.3b) Gecko/20030201

thx for the fast turnaround