190825 - add junk envelope to messages that are junk

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

add junk envelope to messages that are junk

see http://www.mozilla.org/mailnews/specs/spam/ and
http://www.mozilla.org/mailnews/specs/spam/images/Spam5.gif

This will help discoverability, and is needed for stand alone msg window users
to know if a message is junk or not.

Comment 1

[(not reading, please use [e-mail] instead)]

accepting.

Comment 2

[esther]

*** Bug 180010 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

gail, do you have cycles to create a transparent junk icon (like the toolbar
junk icon) for the junk toolbar?

the toolbar icon has a toolbar background to it, if that makes sense.

I'd need modern and classic, if possible.

for now, I'll just use the junk toolbar icon.

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: patch, still working on this but should have a fix soon.

1) make sure ok with stand alone, 3 pane, alt three pane
2) do it as overlay
3) ok with start page, and account central
4) use up to date xul in the bar (see neil's comments in that other bug)
5) clean up UI (better icon, border, color)
6) perf issues?
7) cleaner better design (junk status agnostic?  pass around the message key /
uri?)
8) issue of when switching from two messages, junk to not junk, does the junk
UI stay up?  see my XXX todo comment.

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: changes to get that last patch to actually work, and makes it work on the stand alone msg window, too.

more todo:

1) make sure plays nice with start page
2) make sure to add back "(images not displayed)" text when that actually works

3) make sure switching folder, no message, the thing is hidden.  (try load junk
switch folder)

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: includes some clean up, and some changes for a few other bugs. still a work in progress, but getting closer.

Comment 7

[jglick]

>8) issue of when switching from two messages, junk to not junk, does the junk
>UI stay up?

Junk envelope header would be removed from a msg if it is currently identified
as Junk and marked Not Junk. Also removed when switching from a Junk msg to a
Not Junk msg.

Comment 8

[Samir Gehani]

Mail triage team: nsbeta1+/adt1

Comment 9

[(not reading, please use [e-mail] instead)]

sorry jen, the issue I listed in
http://bugzilla.mozilla.org/show_bug.cgi?id=190825#c4 wasn't a UI issue, it was
a note to myself about something I needed to fix in the code.

the junk bar behaves as you'd expect.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

follows some suggestions neil has made to me in the past
(see http://bugzilla.mozilla.org/show_bug.cgi?id=168236#c6)

[plus some other changes in my tree, which I won't be checking in]

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: just the fix for this bug

Comment 12

[(not reading, please use [e-mail] instead)]

an updated todo list:

1) ok with start page, and account central
2) clean up UI (better icon, border, color)
3) perf issues?
4) cleaner better design (junk status agnostic?  pass around the message key /
uri?)
5) issue of when switching from two messages, junk to not junk, does the junk
UI stay up?  see my XXX todo comment.
6) make sure to add back "(images not displayed)" text when that actually works
7) make sure switching folder, no message, the thing is hidden.  (try load junk
switch folder)

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: patch, more changes (not all for this bug.)

Comment 14

[Asa Dotzler [:asa]]

Not gonna block for this but we'd consider a patch for the branch.

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 16

[(not reading, please use [e-mail] instead)]

fixed, this has r/sr=bienvenu

there are a few cleanup issues, which I'll log as spin off bugs.

Comment 17

[(not reading, please use [e-mail] instead)]

fixed on the trunk, I should say.  let's bake this before taking on the 1.3 branch.

Comment 18

[(not reading, please use [e-mail] instead)]

this fix has a perf regression, but the fix is in hand.

so if this makes it to 1.3 final (I hope it does) the fix for #195354 would be 
a part of it.

Comment 19

[esther]

Using build 20030228 on winxp, linux and mac osx the envelope is:
there for junk mail, 
not there for not junk mail
there when junk mail header switched to all
there for junk mail imap, pop and local 
there when header is collapsed

Verified