Closed
Bug 191548
Opened 22 years ago
Closed 22 years ago
EmbedContentListener needs to support weak references
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
2.03 KB,
patch
|
pavlov
:
review+
blizzard
:
superreview+
asa
:
approval1.3b+
|
Details | Diff | Splinter Review |
There's an assertion on startup of TestGtkEmbed about the content listener not supporting weak references. I suspect something isn't getting hooked up correctly because we fail to get a weak reference.
|
Assignee | |
Comment 1•22 years ago
|
||
|
||
Comment 2•22 years ago
|
||
Comment on attachment 113285 [details] [diff] [review] patch r=pavlov
Attachment #113285 -
Flags: review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #113285 -
Flags: superreview?(blizzard)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 113285 [details] [diff] [review] patch sr=blizzard
Attachment #113285 -
Flags: superreview?(blizzard) → superreview+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #113285 -
Flags: approval1.3b?
Are you sure the assertion isn't http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/docshell/base/nsDSURIContentListener.cpp&rev=1.56&mark=228-235#222 Maybe this is OK? But I also don't see how it could do any harm.
|
|
Assignee | |
Comment 5•22 years ago
|
||
Yeah, I think that's what the assertion is from. So I guess it's not actually causing a problem, but I'd prefer not to get the assertion.
|
||
Comment 6•22 years ago
|
||
Comment on attachment 113285 [details] [diff] [review] patch a=asa
Attachment #113285 -
Flags: approval1.3b? → approval1.3b+
|
|
Assignee | |
Comment 7•22 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•