192447 - Cannot disable JavaScript with new UI

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[noririty]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030208 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030208 Phoenix/0.5

Cannot disable JavaScript using the new preference dialogbox.
This phenomenon was noted after checkin of Bug 191524 (Mega Preferences Reorg.).

Reproducible: Always

Steps to Reproduce:
1.Start Phoenix with a new profile.
2.Open [Tools]-[Options...]-[Web Features].
3.Un-check "Enable JavaScript" checkbox.
4.Click [OK] to close options dialogbox.
5.Reopen [Tools]-[Options...]-[Web Features].
Actual Results:  
"Enable JavaScript" checkbox is checked
 and JavaScript is still enabled.

Expected Results:  
"Enable JavaScript" checkbox must be un-checked
 and JavaScript should be disabled.

This bug has been reported:
http://www.mozillazine.org/forums/viewtopic.php?t=5441
http://bugzilla.mozilla.org/show_bug.cgi?id=191650#c6

Comment 1

[Sébastien Delahaye]

Confirming and reassigning to Ben.

Comment 2

[Sébastien Delahaye]

Actually, you don't even need to close the Options window and to open it again.
Just uncheck "Enable javascript", then switch to another Options panel and
switch back to the Web Features panel, and the pref is checked again.

Comment 3

[noririty]

Attachment: fix

fix Mega Preferences Reorg. regression

Comment 4

[noririty]

Attachment: fix v.2

This version of the patch also fixes the initial button enable/disable.

Comment 5

[Pierre Chanial]

Comment on attachment 115710 [details] [diff] [review]
fix v.2

It was the other way around :)
Thank you for pointing at the problem!

Comment 6

[Pierre Chanial]

fixed.

Comment 7

[noririty]

Attachment: Patch a deficiency

This patch fixes following deficiency.
1. Open [Tools]-[Options…]-[Web Features]
2. Un-check [Enable JavaScript]
*note Advanced button is disabled.
3. Switch to another Options panel and switch back to the Web Features panel.
Actual Results: 
Advanced button is enabled

Expected Results: 
Advanced button should be disabled

Comment 8

[Simon Paquet [:sipaq]]

*** Bug 195228 has been marked as a duplicate of this bug. ***

Comment 9

[Pierre Chanial]

I grabbed today's nightly and it works fine with new profiles and 0.5 profiles.
I experienced a problem with a post pref reorg profile, though.
Try with a new profile.

Comment 10

[Pierre Chanial]

Ooops, sorry, norority, I didn't understand the bug correctly, now the
'advanced' button is really fixed.
Thanks!

Comment 11

[Pierre Chanial]

Comment on attachment 115757 [details] [diff] [review]
Patch a deficiency

I refactored some code, though. but this patch and the previous one were
essentially correct.

Comment 12

[noririty]

Pierre:
Thanks for the review and polishing.

v.