195689 - Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F"

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[km]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030228
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030228

The Edit menu used to have a short cut for "Fill in Form" which was
an "m". Recently, the menu changed and now has the first F underlined.
Since there is an earlier entry "Find in Page" with the first F
also underlined, there is now no keystroke shortcut for "Fill in Form"

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Evzen Polenka]

I can confirm this one.
It's quite annoying, can someone fix it, please? It's been there for quite a
while  and no one seems to care.

Comment 2

[piers]

Ok, confirming this. Finding out from Netscape UE about whether we can remove
these items altogether since they are duplicated under Tools -> Form Manager ->
Fill in Form and Tools -> Form Manager -> Save Form Info.

Comment 3

[piers]

-> Keyboard Navigation

Comment 4

[Mats Palmgren (inactive)]

This is a regression from bug 179661.  Piers, are you working on this?
This actually breaks kbd navigation for "Find in This Page".

Comment 5

[Mats Palmgren (inactive)]

*** Bug 205030 has been marked as a duplicate of this bug. ***

Comment 6

[Mats Palmgren (inactive)]

*** Bug 212052 has been marked as a duplicate of this bug. ***

Comment 7

[piers]

Mats, sorry, i can't work on this at the moment. Please feel free to take the
bug.

Comment 8

[Mats Palmgren (inactive)]

Attachment: Patch

Change accesskey for "Fill in Form" from 'F' to 'i' to avoid clash in Edit menu

with "Find in This Page"

Comment 9

[Mats Palmgren (inactive)]

Taking this...

Comment 10

[Mats Palmgren (inactive)]

"o" is an alternative that would work also if you prefer that.
The underline under "i" is a bit tiny and hard to see perhaps, but it's
used elsewhere (Page Info) so I guess it's OK.

Comment 11

[:deanis74]

<kinda offtopic> Isn't the underline for the 'I' in Page Info wider, though,
since it's a capital 'I'? </kinda offtopic>

This affects the entry under the Tools > Form Manager menu as well, right?

Comment 12

[Mats Palmgren (inactive)]

Yes, it will change the "Fill in Form" entry in both menus.

Regarding the width, a capital 'I' has the same width as 'i' (on Linux anyway)
so the underline will be the same too.
Attaching screenshots...

Comment 13

[Mats Palmgren (inactive)]

Attachment: Screenshot: Tools->Form Manager menu

Comment 14

[Mats Palmgren (inactive)]

Attachment: Screenshot: Edit menu

Comment 15

[Aaron Leventhal]

Comment on attachment 127364 [details] [diff] [review]
Patch

I'm sorry, but we do everything we can to avoid lowercase i or l as accesskeys,
because the underline is so small it's very hard to see.

Our guide for choosing accesskeys is here:
http://www.mozilla.org/projects/ui/accessibility/accesskey.html

Note that we ave some other rules, most of which we picked up from Microsoft's
UI guidelines.

Comment 16

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Comment 17

[Mats Palmgren (inactive)]

Attachment: Screenshot: Tools->Form Manager menu

Comment 18

[Mats Palmgren (inactive)]

Attachment: Screenshot: Edit menu

Comment 19

[Aaron Leventhal]

Comment on attachment 127426 [details] [diff] [review]
Patch rev. 2

Great. Thanks for doing this.

Comment 20

[Jo Hermans]

*** Bug 213784 has been marked as a duplicate of this bug. ***

Comment 21

[Daniel Convissor]

Loaded up the 2003030309 nightly build dated and this bug has been fixed. 
Please mark it as fixed.  Thanks.

Comment 22

[Mats Palmgren (inactive)]

Someone else has already fixed this...

-> WORKSFORME