195886 - unstyled XML display element collapse broken

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[kyles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030303
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030303

1.3 branch build:
load up an unstyled XML file
click on the dash to collapse node
note that nothing happens

note that this works with the 1.3beta build

Reproducible: Always

Steps to Reproduce:

Comment 1

[Boris Zbarsky [:bzbarsky]]

Seeing this on current linux trunk too.  This seems to have regressed between
2003-02-14-08 and 2003-02-14-22 builds, but I see no checkins in that range that
would be likely candidates for regressing this....

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

the problem is that we nowadays don't target events at textnodes but at the
textnodes parent.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 116269 [details] [diff] [review]
patch to fix

r+sr=me; if you want to be really cool, you could check the node type before
getting the parent... ;)

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 116269 [details] [diff] [review]
patch to fix

Right now prettyprinting is very broken. The fix is extreamly safe and will
only affect prettyprinted pages

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to Jonas.

Comment 6

[Brendan Eich [:brendan]]

Any other places in the tree need similar fixing?

/be

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 116269 [details] [diff] [review]
patch to fix

a=asa (on behalf of drivers) for checkin to the 1.3 branch. Time is short and
we won't hold for this but it if makes it into the branch before we make final
builds that'd be nice.

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I searched LXR for "originalTarget.parentNode" and found one other instance in
D&D code, is this broken without a similar fix?:

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsDragAndDrop.js#114

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in on the 1.3 branch

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

jkeiser is working hard at putting out fires caused by the evanttarget change.

Comment 11

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I created bug 196239 to track similar problems elsewhere.