196239 - Change code that depended on events reaching text nodes

Status: NEW

(Core :: DOM: Events, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

One such bug that was just fixed is bug 195886.

I searched LXR for ".parentNode", and then manually for instances where "event"
also appeared and came up with these. Please note that this is still not an
exhaustive list of possible problem spots (I did not catch variable usage for
example, nor C/C++ code):

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsDragAndDrop.js#114
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#517
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#529
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#617
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#619
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdImageMapShapes.js#620
http://lxr.mozilla.org/seamonkey/source/rdf/resources/dom-test-1.xul#95
http://lxr.mozilla.org/seamonkey/source/rdf/resources/dom-test-2.xul#95
http://lxr.mozilla.org/seamonkey/source/rdf/resources/dom-test-3.xul#53
(tests 4, 6 and 8 probably have incorrect usage as well)
http://lxr.mozilla.org/seamonkey/source/rdf/resources/ignore-test.xul#31
http://lxr.mozilla.org/seamonkey/source/rdf/resources/xpidl-test-1.xul#34

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

John, I seem to recall that you made this change. Did you make an attempt to fix
all the callers that depended on the old behavior?

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Hmm, I read my last comment again and I realized it came out differently than I
intended. Sincere apologies, John! I filed this bug to help you find any
remaining issues, not to bash you or anything like that.

Comment 3

[John Keiser (jkeiser)]

I didn't read any bashing into it ... I didn't check all callers, no, just a
rather small sampling and using the browser for a while.  Most of the links here
given are benign (not related to textnode targeting).  I haven't gone through
them all yet.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.