196286 - ftp URLs w/ "anonymous" user should automatically use anonymous password.

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[benc]

STEPS: click on URL
EXPECTED:
Should the browser recognize the user is "anonymous" and automatically use the
built-in anonymous password?
Or maybe pre-populate the password field?

It seems logical.

OBSERVED:
User+password auth dialog (user is pre-filled as anonymous). 

NOTE:
I don't know if there is a difference between:

ftp://ftp.mozilla.org
ftp://[e-mail]

The RFC's don't seem to say. The RFC's also don't seem to suggest clearly what
the author of the URL should expect, this could be considered a way of forcing
the user to manually enter a password.

Comment 1

[Josh Birnbaum]

Testing with IE, both "anonymous" and "ftp" logins are allowed to proceed
without a password prompt.

On second thought, shouldn't the URL ftp://[e-mail] be
interpreted as
server: ftp.mozilla.org
user: anonymous
password: (blank)
as opposed to auto-filling in a password (or prompting).  Disclaimer, I'm not
looking at the RFC right now.

Comment 2

[benc]

well, we have an automatic anonymous password, so maybe filling it in and
auto-hilighting would be the best choice.

Long ago, bug 17661 requested mailnewws integration w/ the anonymous password,
where you might get to use an address configured for a mailbox or newsserver.

Comment 3

[Doug Turner (:dougt)]

Attachment: patch

Comment 4

[Darin Fisher]

Comment on attachment 119514 [details] [diff] [review]
patch

>Index: nsFtpConnectionThread.cpp

>+    if (!uname.IsEmpty() && !uname.Equals(NS_LITERAL_CSTRING("anonymous"))) {
>+        mAnonymous = PR_FALSE;
>+        mUsername = NS_ConvertUTF8toUCS2(NS_UnescapeURL(uname));

pretty busted to treat unescaped username as UTF-8 i would imagine,
but that's another bug :-/

wu-ftpd seems to treat AnOnYmOuS as guest login, so shouldn't the
comparison above be case-insensitive?

Comment 5

[Doug Turner (:dougt)]

on many systems passwords are case-sensitive.  that means you could have a vaild
user "aNoNyMoUs" which is different from the anonymous account.  Therefore we
must use a case sensitive comparison.

I am not going to open the can of worms wrt unescaped usernames as UTF-8 in this
bug. :-)

Comment 6

[Doug Turner (:dougt)]

also see rfc1635.

Comment 7

[Darin Fisher]

Comment on attachment 119514 [details] [diff] [review]
patch

fair enough... thx for the explanation.  sr=me

Comment 8

[Doug Turner (:dougt)]

on many systems *usernames* are case-sensitive -- pw's are almost always case
sensitive now adays. 

Comment 9

[Doug Turner (:dougt)]

Checking in nsFtpConnectionThread.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v  <-- 
nsFtpConnectionThread.cpp
new revision: 1.256; previous revision: 1.255
done

fixed.

Comment 10

[benc]

V/fixed:
Mozilla 1.6, Mac OS X
The URL's w/ "anonymous" as the user now authenticate w/o a prompt, with or w/o
a password in the URL.