197530 - Removal of PPM support

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[tor]

PPM was a handy simple image format for testing when libpr0n was being
written, but has now outlived its time in the mozilla tree.  Removal
gains us about 5K on linux.

Comment 1

[tor]

Attachment: ppm removal

Comment 2

[Boris Zbarsky [:bzbarsky]]

Doesn't biesi's work to make decoders completely pluggable largely obviate these
changes (except the build system ones?).

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

no... they are not yet completely pluggable... most importantly, the image
mimetype sniffing (in imgLoader.cpp) is not pluggable yet...

Comment 4

[tenthumbs]

Well, it doesn't actually work anyway although mozilla recognizes the 
mime type so it's probably not a loss. However, it _is_ a common unix 
format do platform parity rather demands that you also remove bmp 
support as well.

Note that on Linux plugins are rather wedged with respect to large 
objects so it may not be possible to view such an image even with a 
plugin.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

PPM works for me at http://gemal.dk/browserspy/images.html. Directly loading
http://gemal.dk/browserspy/pics/test.ppm also works for me.

Comment 6

[tenthumbs]

Yes, but mozilla doesn't understand the generic anymap (.pnm) form. Apache does
so it sends image/x-portable-anymap which confuses mozilla. Because I often use
my own server to view the file system I see this a lot.

Comment 7

[hacker formerly known as [e-mail]]

Comment on attachment 117314 [details] [diff] [review]
ppm removal

r=cls on the build changes

Comment 8

[Stuart Parmenter]

Comment on attachment 117314 [details] [diff] [review]
ppm removal

r=pavlov

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 117314 [details] [diff] [review]
ppm removal

rs=blizzard

Comment 10

[Jason Mobarak]

Using:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla
Firebird/0.6

when viewing:

http://www.unm.edu/~jmob/images/io.ppm

Colors are switched (i.e. it looks like the red and blue values are switched).

Comment 11

[tor]

Checked in.